Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling validation of checksum for online agent update for ADO OnPrem #3679

Merged
merged 7 commits into from
Dec 28, 2021

Conversation

denis-tikhomirov
Copy link
Contributor

Enabled validation of checksum for online agent update for ADO OnPrem. Previously the validation was actual for Hosted ADO versions.
Validation of checksum is left as disabled for offline agent update (https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/agents?view=azure-devops-2019&tabs=browser#can-i-update-my-v2-agents-that-are-part-of-an-azure-devops-server-pool).

Changes are tested by following cases:

  • ADO On-Premises:
    • Update by button "Update all agents" with enabled network and without package in %ProgramData%\Microsoft\Azure DevOps\Agents - Checksum was successful
    • Update by start new task on agent with enabled network and without package in %ProgramData%\Microsoft\Azure DevOps\Agents - Checksum was successful
    • Update by button "Update all agents" with enabled network and with package in %ProgramData%\Microsoft\Azure DevOps\Agents - Checksum was skipped
    • Update by start new task on agent with enabled network and with package in %ProgramData%\Microsoft\Azure DevOps\Agents - Checksum was skipped
    • Update by button "Update all agents" with disabled network and with package in %ProgramData%\Microsoft\Azure DevOps\Agents - Checksum was skipped
    • Update by start new task on agent with disabled network and with package in %ProgramData%\Microsoft\Azure DevOps\Agents - Checksum was skipped
  • Hosted ADO:
    • Update by button "Update all agents" with enabled network and without package in %ProgramData%\Microsoft\Azure DevOps\Agents - Checksum was successful
    • Update by start new task on agent with enabled network and without package in %ProgramData%\Microsoft\Azure DevOps\Agents - Checksum was successful

Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@denis-tikhomirov denis-tikhomirov merged commit e16a2ee into master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants