[TEE download and removal logic] Fix permissions setting on MacOS #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmod argument order should be different on macos
|
Tested changes end-2-end, all works as expected. Case 1 - clean run
Case 2 - with |
alexander-smolyakov
approved these changes
Jan 19, 2022
anatolybolshakov
approved these changes
Jan 19, 2022
AndreyIvanov42
pushed a commit
that referenced
this pull request
Jan 20, 2022
* fix agentversion, releasenote for hotfix 2.198.1 * [TEE download and removal logic] Fix permissions setting on MacOS (#3704) * fix setting permissions on macos * chmod argument order should be different on macos * cleanup on each download/extraction attempt * Update dumping waagent.conf file logic not to write waning on missed "waagent.conf" Co-authored-by: Daniil Shmelev <72494759+DaniilShmelev@users.noreply.github.com> Co-authored-by: Tatyana Kostromskaya <86476103+tatyana-kostromskaya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've encountered a couple of issues with TEE downloading on macos:
chmodcommand doesn't accept current argument order on macosThis PR should fix them
Initial PR: #3684