Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Agent should gather telemetry on Task runner invocations #3973

Merged
merged 9 commits into from
Oct 13, 2022

Conversation

LiliaSabitova
Copy link
Contributor

@LiliaSabitova LiliaSabitova commented Sep 26, 2022

Description:
Added new telemetry to be able to track task invocations distributed by runner.
This is needed to track progress with Node runner upgrades for tasks we don't own (Marketplace tasks).
Data collected:

  • Task Name
  • Task ID
  • Version (Major/Minor/Patch)
  • OS
  • Expected Execution Handler
  • Real Execution Handler
  • UseNode10
  • PlanId
  • JobId

PlanId and JobId are collected for the purpose of using them in joining tables in Kusto query

Changelog:

  • Added new function PublishTelemetry in Agent.Worker/TaskRunner.cs to prepare and publish telemetry data
  • Added call of the new function PublishTelemetry in RunAsync method of TaskRunner
  • Existing TelemetryCommandExtension and PublishTelemetryCommand classes of Agent Worker are used for publishing telemetry data

Documentation changes required:

  • Yes

Added unit tests:

  • NO

Attached related issue:

  • Link to PR in the issue

Checklist:

  • There are no risky dependency updates
  • Changes have been tested

@LiliaSabitova
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Akvelon"

1 similar comment
@LiliaSabitova
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Akvelon"

src/Agent.Worker/TaskRunner.cs Outdated Show resolved Hide resolved
src/Agent.Worker/TaskRunner.cs Show resolved Hide resolved
src/Agent.Worker/TaskRunner.cs Show resolved Hide resolved
src/Agent.Worker/TaskRunner.cs Outdated Show resolved Hide resolved
src/Agent.Worker/TaskRunner.cs Outdated Show resolved Hide resolved
LiliaSabitova and others added 3 commits October 10, 2022 09:07
Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com>
Added JobId and PlanId, removed spaces in telemetry data names
@LiliaSabitova LiliaSabitova changed the title FEATURE 1975785 Agent should gather telemetry on Task runner invocations FEATURE Agent should gather telemetry on Task runner invocations Oct 12, 2022
@LiliaSabitova LiliaSabitova changed the title FEATURE Agent should gather telemetry on Task runner invocations FEATURE: Agent should gather telemetry on Task runner invocations Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants