Fix vso commands execution in vulnerable variables #3987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roman-Shchukin
approved these changes
Oct 17, 2022
vmapetr
approved these changes
Oct 17, 2022
kirill-ivlev
approved these changes
Oct 20, 2022
max-zaytsev
approved these changes
Oct 25, 2022
wojgasior
approved these changes
Oct 27, 2022
|
not added trace events to debug potential problems, will do |
…-agent into users/KonstantinTyukalov/Fix_vso_commands_exec
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
*.DefinitionNameand*.SourceVersionMessagemay contain vso commands which will be executed if it will be specified in script as outputWe want to prevent this behavior by deactivating commands in this variables
Changelog:
DeactivateVsoCommandsutil which disables all vso commands in line