Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not mask tasks banner #4013

Merged

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Oct 31, 2022

Description: Task banner should not contain any sensitive data, it means we should not mask anything here.

Changes:

  • Extend Write & Output allowing to pass canMaskSecrets flag
  • Disable masking for the task metadata
  • Updated mocks for testing
  • Minor formatting

Related issue: #1207

Checklist:

  • There are no risky dependency updates
  • Changes have been tested

@KonstantinTyukalov KonstantinTyukalov changed the title Users/konstantin tyukalov/not mask task banner Not mask tasks banner Oct 31, 2022
@KonstantinTyukalov KonstantinTyukalov marked this pull request as ready for review November 29, 2022 15:31
@KonstantinTyukalov KonstantinTyukalov merged commit a94f6d9 into master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants