Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET 3.1 Agent to never upgrade to .NET 6 on unsupported OS #4064

Merged

Conversation

sergey-koryshev
Copy link
Contributor

Feature description:
Need to implement logic to prevent updating pipelines agent to .NET 6 version on systems which doesn't support it. To check if system supports .NET 6 we decided to use some kind of whitelist of systems

Implementation description:
I have implemented new methods in PlatformUtil to get name and version of system to identify it more precisely. UpdateNeeded of class SelfUpdater was modified to check if current system supports .NET 6 by checking whitelist named net6.json. If system doesn't support we write a note in logs and skip the update. The check happens only if customer has agent of version 2.x and server reports that last version is 3.x

Documentation changes required: No

Added unit tests: No

@sergey-koryshev sergey-koryshev marked this pull request as ready for review November 18, 2022 15:00
@sergey-koryshev sergey-koryshev requested review from a team as code owners November 18, 2022 15:00
src/Agent.Sdk/Util/PlatformUtil.cs Outdated Show resolved Hide resolved
src/Agent.Listener/SelfUpdater.cs Outdated Show resolved Hide resolved
src/Agent.Listener/SelfUpdater.cs Show resolved Hide resolved
@sergey-koryshev sergey-koryshev merged commit fa847fe into master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants