New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET 3.1 Agent to never upgrade to .NET 6 on unsupported OS #4064
Merged
sergey-koryshev
merged 21 commits into
master
from
users/sergey.koryshev/1994084-prevent-updating-to-net6
Nov 30, 2022
Merged
Update .NET 3.1 Agent to never upgrade to .NET 6 on unsupported OS #4064
sergey-koryshev
merged 21 commits into
master
from
users/sergey.koryshev/1994084-prevent-updating-to-net6
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmapetr
approved these changes
Nov 18, 2022
ismayilov-ismayil
approved these changes
Nov 22, 2022
kirill-ivlev
approved these changes
Nov 29, 2022
kirill-ivlev
approved these changes
Nov 30, 2022
wojgasior
approved these changes
Nov 30, 2022
Roman-Shchukin
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature description:
Need to implement logic to prevent updating pipelines agent to
.NET 6
version on systems which doesn't support it. To check if system supports.NET 6
we decided to use some kind of whitelist of systemsImplementation description:
I have implemented new methods in
PlatformUtil
to get name and version of system to identify it more precisely.UpdateNeeded
of classSelfUpdater
was modified to check if current system supports.NET 6
by checking whitelist namednet6.json
. If system doesn't support we write a note in logs and skip the update. The check happens only if customer has agent of version2.x
and server reports that last version is3.x
Documentation changes required: No
Added unit tests: No