Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support to Pipeline Artifact and Pipeline Caching, for larger chunk size. #4157

Merged
merged 23 commits into from
Jun 12, 2023
Merged

Adding support to Pipeline Artifact and Pipeline Caching, for larger chunk size. #4157

merged 23 commits into from
Jun 12, 2023

Conversation

fadnavistanmay
Copy link
Collaborator

@fadnavistanmay fadnavistanmay commented Feb 9, 2023 •
edited
Loading

Adding support to Pipeline Artifact and Pipeline Caching, for larger chunk size.

@fadnavistanmay fadnavistanmay changed the title Users/tafadnav/pipelineartbigchunks Adding support to Pipeline Artifact and Pipeline Caching, for larger chunk size. Apr 25, 2023
@fadnavistanmay fadnavistanmay marked this pull request as ready for review April 25, 2023 17:23
@fadnavistanmay fadnavistanmay requested review from a team as code owners April 25, 2023 17:23
carl-tanner
carl-tanner reviewed May 2, 2023
View reviewed changes
Copy link
Member

@carl-tanner carl-tanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Microsoft.VisualStudio.Services.Agent/Blob/DedupManifestArtifactClientFactory.cs Outdated Show resolved Hide resolved
merlynomsft
merlynomsft approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@merlynomsft merlynomsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@merlynomsft merlynomsft merged commit 22d4a72 into microsoft:master Jun 12, 2023
8 checks passed
@johnterickson
Copy link
Contributor

namespace Agent.Plugins

we shouldn't have any code in this class, right?

Refers to: src/Agent.Plugins/Artifact/FileShareProvider.cs:28 in 40d8bef. [](commit_id = 40d8bef, deletion_comment = False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-tanner carl-tanner carl-tanner approved these changes

@b-barthel b-barthel b-barthel approved these changes

@merlynomsft merlynomsft merlynomsft approved these changes

Assignees
No one assigned
Labels
Area: Agent enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fadnavistanmay @johnterickson @carl-tanner @b-barthel @merlynomsft @kirill-ivlev