Pass Process handler args through env variables #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pipelines-agent into users/KonstantinTyukalov/Secure_process_handler_poc
ismayilov-ismayil
approved these changes
May 2, 2023
sergey-koryshev
approved these changes
May 3, 2023
LiliaSabitova
approved these changes
May 4, 2023
PavloAndriiesh
approved these changes
May 5, 2023
kirill-ivlev
added a commit
that referenced
this pull request
May 19, 2023
* Add SecureArguments and script generator * Fix variable expanding * Add ProcessHandlerHelper * Add tests for helper * Use helper in PH * Move constants to function * Add knobs * Add telemetry publishing * Fix args passing * Remove SecureArguments PH Data param * Add random Id to script name * Add description for knobs * Rename feature for telemetry * Make telemetry data as numbers * Update tests --------- Co-authored-by: Kirill Ivlev <102740624+kirill-ivlev@users.noreply.github.com>
kirill-ivlev
added a commit
that referenced
this pull request
May 19, 2023
* Pass Process handler args through env variables (#4259) * Add SecureArguments and script generator * Fix variable expanding * Add ProcessHandlerHelper * Add tests for helper * Use helper in PH * Move constants to function * Add knobs * Add telemetry publishing * Fix args passing * Remove SecureArguments PH Data param * Add random Id to script name * Add description for knobs * Rename feature for telemetry * Make telemetry data as numbers * Update tests --------- Co-authored-by: Kirill Ivlev <102740624+kirill-ivlev@users.noreply.github.com> * Fix PH telemetry debug formatting (#4282) * Fix telemetry debug message * Remove extra import * Upd formatting --------- Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item: internal 2048209
The new logic is hidden under knobs: