Add resource utilization warnings #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DergachevE
reviewed
Dec 14, 2023
DergachevE
reviewed
Dec 14, 2023
DergachevE
reviewed
Dec 14, 2023
DergachevE
requested changes
Dec 14, 2023
vmapetr
changed the title
vmapetr
force-pushed
the
v-mpetrov/us-2127964-Provide-discoverable-resource-utilization-information
branch
from
e7d85ce
to
1b7f6db
Compare
|
There was an error handling pipeline event b6bb09f4-db76-4f54-b6f1-20e3b9c50093. |
vmapetr
force-pushed
the
v-mpetrov/us-2127964-Provide-discoverable-resource-utilization-information
branch
from
a0c5bae
to
f018a53
Compare
vmapetr
changed the title
vmapetr
force-pushed
the
v-mpetrov/us-2127964-Provide-discoverable-resource-utilization-information
branch
from
5e75f61
to
bdee0a6
Compare
…resource-utilization-information
DmitriiBobreshev
approved these changes
Jan 8, 2024
DmitriiBobreshev
approved these changes
Jan 8, 2024
ivanduplenskikh
approved these changes
Jan 8, 2024
DenisRumyantsev
approved these changes
Jan 8, 2024
merlynomsft
reviewed
Jan 8, 2024
merlynomsft
reviewed
Jan 8, 2024
merlynomsft
reviewed
Jan 8, 2024
merlynomsft
reviewed
Jan 8, 2024
…ization-information' of https://github.com/microsoft/azure-pipelines-agent into v-mpetrov/us-2127964-Provide-discoverable-resource-utilization-information
ismayilov-ismayil
approved these changes
Jan 10, 2024
DergachevE
reviewed
Jan 11, 2024
DergachevE
reviewed
Jan 11, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
max-zaytsev
approved these changes
Jan 16, 2024
…resource-utilization-information
…resource-utilization-information
DergachevE
approved these changes
Jan 17, 2024
…resource-utilization-information
…resource-utilization-information
vmapetr
added a commit
that referenced
this pull request
Feb 20, 2024
* Add resource utilization warnings and telemetery * Remove excessive error handling in CPU monitor * Fix casting for macos memory monitor * Hide internal monitor methods * Remove custom exception * Minor fix in comment * Fix typos --------- Co-authored-by: Ivan Duplenskikh <115665590+ivanduplenskikh@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ADO warnings in case if disc or memory resource utilization exceeds 95%. It also add telemetry for high CPU usage.
Changes:
ResourceMetricsManagerwere reworked.ResourceMetricsManager.ResourceMetricsManagerenabled inTaskRunner.ADOwarnings in case of high disc space or memory utilization.EnableResourceUtilizationWarningsis added.Testing:
Validated on Windows 11 / Ubuntu 22.04 / MacOS 14.0 / CentOS 7 (Docker)
Buddy-tested by @kirill-ivlev
How it was tested:
Agent was built with memory and disk space thresholds set to 99% percent.
Related WI: 2127964