Mask ACR token on Windows when System.Debug is true #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Added refresh token to secret masker -- Added FF to use --password-stdin on windows
|
✅ Successfully linked to Azure Boards work item(s): |
aleksandrlevochkin
requested changes
Jun 25, 2024
-- Removed PipelineFeatureSource -- Fixed review points
-- Removed Env source
KonstantinTyukalov
approved these changes
Jun 25, 2024
aleksandrlevochkin
approved these changes
Jun 25, 2024
vmapetr
approved these changes
Jun 26, 2024
DergachevE
approved these changes
Jun 26, 2024
DmitriiBobreshev
deleted the
users/v-bobreshevd/docker-use-stdin-on-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
-- Added refresh token to secret masker
-- Added Knob to use --password-stdin on windows
Related WI: AB#2174985
Testing:
Tested with ACR token on test tenant. Refresh-token masked if we use --password argument:
And passed via stdin if the knob is enabled