Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable large numbers of children to be pushed in find #509

Merged
merged 4 commits into from
May 1, 2019

Conversation

damccorm
Copy link

Right now, if there are too many childItems this exceeds the stack call size. This fixes this problem by pushing them one by one instead of with the operator.

Fixes #408

@duncanp-sonar
Copy link

Could you give an update of the status of this PR please? I believe the underlying issue is still causing problems for users of our extension. Thanks!

@stephenmichaelf
Copy link
Member

Do we have tests that cover this functionality to make sure we have kept things consistent?

@damccorm
Copy link
Author

Yeah, this should be covered by the findMatch tests and the find tests

@stephenmichaelf
Copy link
Member

Approve.

Let's bump the patch version.

@damccorm damccorm merged commit 478c983 into master May 1, 2019
@damccorm damccorm deleted the users/damccorm/large-finds branch May 1, 2019 20:05
fullstackinfo pushed a commit to fullstackinfo/azure-pipelines-task-lib that referenced this pull request Aug 17, 2024
* Get rid of ... operator and reverse

* Update package.json

* Update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed find: Maximum call stack size exceeded
3 participants