Fix rmrf and drop version to 2.9.0 #531
Conversation
|
Can we add more details to this? What are we fixing? What's the new implementation? How is it different? Good to have for historical context. |
|
Are there tests that cover this? Do we need more? |
|
Sure, for context we're trying to solve the issue here. To summarize, nodes unlinkSync doesn't always actually delete a file, it just decrements its ref-count (which eventually has the effect of deleting it). This means that if the file is open elsewhere (often with antivirus software its being scanned) it doesn't actually get immediately deleted. This tries to address that. I think existing coverage does a pretty good job with this, not really sure if there's a good way to test that exact behavior. Since we're not using unlinkSync, that edge case should just be avoided entirely anyways. |
|
Looks good, let's have Eric review before merging. |
node/task.ts
Outdated
| // program (e.g. antivirus), it won't be deleted. To address this, we shell out the work to rd/del. | ||
| try { | ||
| if (fs.statSync(inputPath).isDirectory()) { | ||
| debug('removing directory'); |
There was a problem hiding this comment.
is there a reason to not put the path you are trying to delete in the debug message?
|
I'm intentionally not updating the version in package.json. We should probably release all the changes going in and need to follow up in the release notes when we do. |
(microsoft/azure-pipelines-task-lib#531) Moved 'mark success' to the end to fix minor issue of the logs saying that the build was successful but then failing
(microsoft/azure-pipelines-task-lib#531) Moved 'mark success' to the end to fix minor issue of the logs saying that the build was successful but then failing
(microsoft/azure-pipelines-task-lib#531) Moved 'mark success' to the end to fix minor issue of the logs saying that the build was successful but then failing
* Fix rmrf and drop version to 2.9.0 * Handle case where it already doesn't exist * Remove extra brace * Use old linux behavior * Consistent logging * Don't mix implementations * Add explanatory comment * Better debugging
Current published version is 2.8.0. Probably not going to major version at this time.