Update tasks to azure-pipelines-task-lib 2.8.0 #10762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmgross
requested review from
cltshivash,
jotaylo,
keljos,
lkillgore,
madhurig and
nigurr
as code owners
keljos
reviewed
Jul 1, 2019
|
I ported over the legacy tests for MavenV3 and XamarinAndroid. Most of them are intact, a few I deemed were duplicate and not ported over. For Maven, I left out a few that weren't really testing anything MavenV3 task-related (such as common package tests) as those are now mocked out. |
jotaylo
reviewed
Jul 2, 2019
brcrista
reviewed
Jul 3, 2019
| @@ -0,0 +1,271 @@ | |||
| /// <reference path="../../definitions/mocha.d.ts"/> | |||
There was a problem hiding this comment.
how come we're adding a legacy test?
There was a problem hiding this comment.
These tests were in the Maven legacy tests and don't need to be ported over.
brcrista
approved these changes
Jul 3, 2019
keljos
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating a bunch of related tasks to
azure-pipelines-task-lib 2.8.0Change list:
ANTV1
azure-pipelines-task-lib 2.8.0GradleV2
azure-pipelines-task-lib 2.8.0Common/Utility-Common(getSystemAccessTokenMavenV2
azure-pipelines-task-lib 2.8.0pacakaging-common-oldtopackaging-commonMavenV3
azure-pipelines-task-lib 2.8.0pacakaging-common-oldtopackaging-commonXamarinAndroidV1
azure-pipelines-task-lib 2.8.0Common/MSBuildHelpers(getMSBuildPath)PublishCodeCoverageResultsV1
Common\codecoverage-toolsCommon tasks updated to
azure-pipelines-task-lib 2.8.0:packaging-common-old
Tested via build canaries for ANTV1, GradleV2, MavenV2, MavenV3, XamarinAndroidV1, and PublishCodeCoverageResultsV1