Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoveragePublisher common library and PublishCodeCoverageV2 #11144

Merged
merged 26 commits into from
Sep 24, 2019

Conversation

karanjitsingh
Copy link
Contributor

Change 1

PR introduces a library coveragepublisher in Tasks/Common, this library will henceforth be used for all coverage publishing needs for existing/new tasks. The library is packed with a dotnet library from azure blob, which performs parsing and the report generation. The task side coveragepublisher library simply acts as a wrapper to this.

Change 2

Bump publish code coverage to V2.

  • Use the common coverage publisher library
    • Task can now support taking in multiple inputs mixed with multiple formats
    • Will now support local merging
    • Will support future coverage improvements
  • Remove the redundant tool input and report directory input.

image

package.json Outdated Show resolved Hide resolved
@karanjitsingh karanjitsingh merged commit 5d99f82 into microsoft:master Sep 24, 2019
@bkaid
Copy link

bkaid commented Oct 16, 2019

Any idea when this new version will be published? Will simplify and speed up some builds I have. Thanks!

@karanjitsingh
Copy link
Contributor Author

Any idea when this new version will be published? Will simplify and speed up some builds I have. Thanks!
@PBoraMSFT on the ETA

@bkaid, btw you can try out the task on your account using https://github.com/microsoft/tfs-cli/blob/master/docs/buildtasks.md

@karanjitsingh karanjitsingh deleted the coveragepublisher branch October 17, 2019 02:36
@PBoraMSFT
Copy link
Member

@bkaid - we are looking at end of the quarter to ship these changes. Some of associated code coverage reporting experiences are changing as well and they need to go in tandem.

@eric-labelle
Copy link

How can we monitor when this task is made public? Since the task has already been merged on master I assume it's already there but "public": true is not present in your manifest? Since your manifests are not in the repository, it's hard to know why a certain task is not available. I had to dig deep just to find this issue mentioning PublishCodeCoverageV2

Is there a release note somewhere for improvements to all your tasks? Mostly what changed from V1 to V2.. or V2 to V3 etc.

@PBoraMSFT
Copy link
Member

@eric-labelle - we publish release notes every sprint for Azure DevOps here. When the task becomes publicly available, information about changes will appear there.

To provide context, we are working on native code coverage reporting experiences in Azure Pipelines. This task revision is a part of that. We expect it to become available early next quarter.

@eric-labelle
Copy link

eric-labelle commented Nov 14, 2019

Allright, thanks @PBoraMSFT !
One more thing though, I was curious and uploaded the V2 to see if speed was improved. I modified the id and name in V2/task.json before uploading V2 but it still was uploaded with original id. I now cannot remove this V2 from my azure organization without completely deleting the V1 also.

Before I uploaded V2 (2.159.0 is latest on master) it was 1.160.1. I tried to reupload V1 with --overwrite without success. If I want to restore the original 1.160.1, how can I achieve this?


Edit: Allright, nevermind. I risked deleting it hoping it would restore the original. It apparently did! :) This should be documented here I think.

Oh and I found why the task was not published as a separate task. I had changed the task.json but not the task.loc.json :(

@IvanAlekseev
Copy link

@karanjitsingh @PBoraMSFT Is there any update on this? It would be great to remove some extra report generator merging steps from my pipelines

@mustafababil
Copy link

Hi folks, how is the plan on publishing new update for task? Will it be available soon at least for preview mode?

@MisinformedDNA
Copy link
Contributor

@PBoraMSFT Any update? It's getting close to 2 years since this PR was merged.

@abatishchev
Copy link

@PBoraMSFT ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants