Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureSpringCloudV0] fix aysnc header #16444

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

RuoyuWang-MS
Copy link
Member

Task name: AzureSpringCloudV0

Description: Our aysnc operation await logic has a bug that it will return when the aync opetion has not completed. We fix this bug in this PR refer to this doc: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#202-accepted-and-location-headers

Documentation changes required: N

Added unit tests: (Y/N) N

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@RuoyuWang-MS RuoyuWang-MS changed the title fix aysnc header [AzureSpringCloudV0] fix aysnc header Jun 13, 2022
@RuoyuWang-MS
Copy link
Member Author

RuoyuWang-MS commented Jun 13, 2022

@anatolybolshakov @mmrazik
Hi Anatolii, Martin. Would you please help review this PR about AzureSpringCloudV0? It is a quick fix and has been tested E2E by publishing private build.
As the issue may have some customer impact, we want to release the change as soon as possible.
Would you please help confirm when is the earliest date to release the change? I am not sure if we can catch this sprint code cut but I wish I could.
Thanks in advance!

@mmrazik
Copy link
Contributor

mmrazik commented Jun 13, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@RuoyuWang-MS
Copy link
Member Author

RuoyuWang-MS commented Jun 13, 2022

@mmrazik Thank you very much!
Would you please help merge this PR when you are free?
By the way, Would you please also help confirm when the changes can be released or where I can see the release progress?
Sincerely thanks again!

@RuoyuWang-MS
Copy link
Member Author

@microsoft/akvelon-build-task-team
Hi team, would you please help merge this PR and confirm the release date?
Thanks a lot!

@@ -19,7 +19,7 @@
"version": {
"Major": 0,
"Minor": 206,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump the task version since we are in the 207th sprint now?

@alexander-smolyakov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@alexander-smolyakov alexander-smolyakov merged commit 1831b14 into microsoft:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants