Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability fix for DownloadPackageV1 #16703

Merged

Conversation

v-mohithgc
Copy link
Contributor

@v-mohithgc v-mohithgc commented Aug 9, 2022

Task name: DownloadPackageV1

Description:

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected
  • node make.js build --task DownloadPackageV1
  • node make.js test --task DownloadPackageV1

@v-nagarajku
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@rajnish-byte
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@rajnish-byte rajnish-byte merged commit 9a85d41 into microsoft:master Aug 9, 2022
v-mohithgc added a commit to v-mohithgc/azure-pipelines-tasks that referenced this pull request Aug 25, 2022
@magleaso
Copy link
Contributor

@rajnish-byte 2 questions:

  • Why did this get merged without our team's approval as code owners? This created a livesite incident.
  • Why was the task version not bumped in this PR?

cc @phil-hodgson

@magleaso
Copy link
Contributor

Incident 330053957 : TypeError in Download Package step for Build Pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants