Added retrials for KeyVault secrets downloading on request timeout #16882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starkmsu
force-pushed
the
kv-secrets-download-retrials
branch
from
ba81b39
to
855a480
Compare
mmrazik
reviewed
Sep 13, 2022
ghost
reviewed
Sep 14, 2022
starkmsu
force-pushed
the
kv-secrets-download-retrials
branch
from
9955799
to
be55f45
Compare
onetocny
approved these changes
Sep 16, 2022
rohit-batra
reviewed
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureKeyVaultV2
Description: Extended retry logic for KeyVaultClient added addition processing for request timeouts that were not handled by the previous logic.
Documentation changes required: N
Added unit tests: N
Attached related issue: N
Checklist: