Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TwineAuthenticateV0 CG Removed Unused Dependency #18427

Merged
merged 7 commits into from
Jun 5, 2023
Merged

TwineAuthenticateV0 CG Removed Unused Dependency #18427

merged 7 commits into from
Jun 5, 2023

Conversation

tintse-thxsky-MSFT
Copy link
Contributor

@tintse-thxsky-MSFT tintse-thxsky-MSFT commented Jun 2, 2023 •
edited

Task name: TwineAuthenticateV0

Description: Fixing CG, turns on the dependency is unused. So I removed it.

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@tintse-thxsky-MSFT tintse-thxsky-MSFT requested a review from a team as a code owner June 2, 2023 19:11
AlexVTor
AlexVTor approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@AlexVTor AlexVTor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tintse-thxsky-MSFT tintse-thxsky-MSFT merged commit 2920385 into master Jun 5, 2023
12 checks passed
@tintse-thxsky-MSFT tintse-thxsky-MSFT deleted the CVE-2021-23358 branch June 5, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVTor AlexVTor AlexVTor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tintse-thxsky-MSFT @AlexVTor