Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Adding http proxy environment variables to Azure CLI V2" #19043

Merged
8 commits merged into from
Oct 2, 2023
Merged

Revert "Adding http proxy environment variables to Azure CLI V2" #19043

8 commits merged into from
Oct 2, 2023

Conversation

merlynomsft
Copy link
Contributor

Reverts #18295 #19042

@merlynomsft merlynomsft marked this pull request as ready for review September 28, 2023 21:19
v-mohithgc
v-mohithgc approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@v-mohithgc v-mohithgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Merlyn for creating this revert PR.
LGTM, but I'm not sure if package-lock.json of the root folder is required for this revert.
Thanks.

@ghost ghost merged commit 0a4bb4b into master Oct 2, 2023
9 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipsonJoseph PhilipsonJoseph PhilipsonJoseph approved these changes

@v-mohithgc v-mohithgc v-mohithgc approved these changes

@rvairavelu rvairavelu Awaiting requested review from rvairavelu

@manolerazvan manolerazvan Awaiting requested review from manolerazvan manolerazvan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@merlynomsft @PhilipsonJoseph @v-mohithgc @ozanMSFT