Adding http proxy environment variables to Azure CLI V2 #18295

ycamargo · 2023-05-16T21:47:17Z

Task name: Azure CLI V2

Description: Adding http proxy environment variables (http_proxy and https_proxy) to azureclitask.ts when proxy configuration is present.

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) Azure CLI Extension V2 is not respecting the .proxy file...

Checklist:

Task version was bumped - please check instruction how to do it
Checked that applied changes work as expected

Adding http proxy environment variables (http_proxy and https_proxy) to azureclitask.ts when proxy configuration is present.

ycamargo · 2023-05-16T21:49:06Z

@microsoft-github-policy-service agree

ycamargo · 2023-07-27T18:22:31Z

@rvairavelu / @manolerazvan could one of you please review and approve this PR?

v-mohithgc · 2023-07-28T05:19:43Z

/azp run

azure-pipelines · 2023-07-28T05:20:10Z

Azure Pipelines successfully started running 4 pipeline(s).

ycamargo · 2023-07-28T14:37:31Z

/azp run

azure-pipelines · 2023-07-28T14:37:37Z

Commenter does not have sufficient privileges for PR 18295 in repo microsoft/azure-pipelines-tasks

v-mohithgc · 2023-07-28T14:43:43Z

Hi @ycamargo , firstly thanks for contributing here.
Looks like there is a build failure because of the changes done in this PR.
Please fix and follow the below steps:

If you have cloned this repo locally, navigate to the root directory (ie C:...\azure-pipelines-tasks>)

Execute this build command " node make.js build --task AzureCLIV2 " //ensure to use node 8/10, else the command fails.
Once the build is completed/successful, commit the changes to this branch.
Thanks

v-mohithgc · 2023-07-28T14:48:27Z

Build failure detail:

2023-07-28T05:21:34.6058540Z Building: AzureCLIV2
2023-07-28T05:21:34.6058947Z ------------------------------------------------------------
2023-07-28T05:21:34.6110704Z
2023-07-28T05:21:34.6111747Z > cd Tasks/AzureCLIV2
2023-07-28T05:21:34.6112155Z Detected Typescript version: 4.0.2
2023-07-28T05:21:34.6112335Z
2023-07-28T05:21:34.6112571Z > npm install
2023-07-28T05:21:38.4194999Z
2023-07-28T05:21:38.4196828Z > cd Tests
2023-07-28T05:21:38.4199852Z
2023-07-28T05:21:38.4200503Z > npm install
2023-07-28T05:21:39.3611668Z
2023-07-28T05:21:39.3613715Z > cd ..
2023-07-28T05:21:39.3617987Z
2023-07-28T05:21:39.3619402Z > node /home/vsts/work/1/s/Tasks/AzureCLIV2/node_modules/typescript/bin/tsc --outDir "/home/vsts/work/1/s/_build/Tasks/AzureCLIV2" --rootDir "/home/vsts/work/1/s/Tasks/AzureCLIV2"
2023-07-28T05:21:47.8136119Z ,azureclitask.ts(19,28): error TS2339: Property 'getProxyConfiguration' does not exist on type 'typeof import("/home/vsts/work/1/s/Tasks/AzureCLIV2/node_modules/azure-pipelines-task-lib/task")'.
2023-07-28T05:21:47.8137772Z ,
2023-07-28T05:21:47.8276890Z ##[error]Bash exited with code '1'.
2023-07-28T05:21:47.8343199Z ##[section]Finishing: Build Tasks

ycamargo · 2023-07-28T15:44:39Z

Hi @ycamargo , firstly thanks for contributing here. Looks like there is a build failure because of the changes done in this PR. Please fix and follow the below steps:

If you have cloned this repo locally, navigate to the root directory (ie C:...\azure-pipelines-tasks>)

Execute this build command " node make.js build --task AzureCLIV2 " //ensure to use node 8/10, else the command fails. Once the build is completed/successful, commit the changes to this branch. Thanks

Hi @v-mohithgc,
I found the issue. There is a problem on the documentation of the Proxy module that drove me to write this wrongfully.
I have even opened a new issue on the azure-pipelines-task-lib repo to fix the documentation.

I've fixed it and built locally without any issues (see evidence below).

C:\git\github\azure-pipelines-tasks>node make.js build --task AzureCLIV2

> prepending PATH C:\git\github\azure-pipelines-tasks\node_modules\.bin
tsc tool:
Version 4.0.2
C:\GIT\GITHUB\AZURE-PIPELINES-TASKS\NODE_MODULES\.BIN\TSC.CMD
npm tool:
6.14.12
C:\PROGRAM FILES\NODEJS\NPM.CMD

------------------------------------------------------------
Building: AzureCLIV2
------------------------------------------------------------

> cd Tasks\AzureCLIV2
Detected Typescript version: 4.0.2

> npm install

> cd Tests

> npm install

> cd ..

> node C:\git\github\azure-pipelines-tasks\Tasks\AzureCLIV2\node_modules\typescript\bin\tsc --outDir "C:\git\github\azure-pipelines-tasks\_build\Tasks\AzureCLIV2" --rootDir "C:\git\github\azure-pipelines-tasks\Tasks\AzureCLIV2"

> cd ..\..

> copying task resources
copying *.ps1
copying *.psd1
copying *.psm1
copying *.sh
copying *.txt
copying icon.png
copying icon.svg
copying module.json
copying node_modules
copying package.json
copying Strings
copying task.json
copying task.loc.json
copying Tests

Build successful

v-mohithgc · 2023-07-28T15:52:12Z

/azp run

azure-pipelines · 2023-07-28T15:52:34Z

Azure Pipelines successfully started running 4 pipeline(s).

v-mohithgc · 2023-09-06T06:43:37Z

/azp run

azure-pipelines · 2023-09-06T06:44:01Z

Azure Pipelines successfully started running 4 pipeline(s).

kirill-ivlev · 2023-09-06T09:37:28Z

/azp run

azure-pipelines · 2023-09-06T09:37:52Z

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines · 2023-09-06T11:36:47Z

Azure Pipelines successfully started running 4 pipeline(s).

v-mohithgc · 2023-09-08T06:07:08Z

/azp run

azure-pipelines · 2023-09-08T06:07:31Z

Azure Pipelines successfully started running 4 pipeline(s).

v-mohithgc · 2023-09-11T05:59:47Z

/azp run

azure-pipelines · 2023-09-11T06:00:14Z

Azure Pipelines successfully started running 4 pipeline(s).

v-mohithgc · 2023-09-11T10:19:39Z

/azp run

azure-pipelines · 2023-09-11T10:20:01Z

Azure Pipelines successfully started running 4 pipeline(s).

v-mohithgc · 2023-09-12T06:39:37Z

/azp run

azure-pipelines · 2023-09-12T06:39:59Z

Azure Pipelines successfully started running 4 pipeline(s).

v-mohithgc · 2023-09-12T08:42:04Z

/azp run

azure-pipelines · 2023-09-12T08:42:30Z

Azure Pipelines successfully started running 4 pipeline(s).

v-mohithgc · 2023-09-12T11:20:28Z

/azp run

azure-pipelines · 2023-09-12T11:20:50Z

Azure Pipelines successfully started running 4 pipeline(s).

This reverts commit d2cd595.

) * Revert "Adding http proxy environment variables to Azure CLIV2 (#18295)" This reverts commit d2cd595. * Update task.json * Update task.loc.json * CI * reset root package-lock.json --------- Co-authored-by: Mohith <97882857+v-mohithgc@users.noreply.github.com> Co-authored-by: Ozan AYDIN <ozanaydin@microsoft.com>

ycamargo added 3 commits May 16, 2023 16:34

Adding http proxy variables to azureclitask.ts

24c40dc

Adding http proxy environment variables (http_proxy and https_proxy) to azureclitask.ts when proxy configuration is present.

Version bump on task.json

9f176c6

Version bump on task.loc.json

97379c5

ycamargo requested review from rvairavelu and manolerazvan as code owners May 16, 2023 21:47

ycamargo and others added 9 commits May 17, 2023 10:31

Merge branch 'master' into master

280b1a8

Version pump to the current minor

3183ef6

Merge branch 'master' into master

f99dcc1

Merge branch 'master' into master

385aea5

Merge branch 'master' into master

55c8b9b

Merge branch 'master' into master

c14e655

Merge branch 'master' into master

1cda278

Minor version pump to the current sprint: 226

f604601

Merge branch 'master' into master

e80b4ce

Merge branch 'master' into master

44011bd

Merge branch 'master' into master

badf0c8

Fixing Proxy configuration function name

566ed47

Merge branch 'master' into master

2b38d2d

task.loc.json updated by local build

325e9f3

Merge branch 'master' into master

63cb591

Merge branch 'master' into master

15d2f2d

Merge branch 'master' into master

a2ba664

rvairavelu approved these changes Sep 11, 2023

View reviewed changes

Merge branch 'master' into master

26be2a9

PhilipsonJoseph approved these changes Sep 12, 2023

View reviewed changes

Merge branch 'master' into master

826c405

v-mohithgc merged commit d2cd595 into microsoft:master Sep 12, 2023
8 checks passed

v-mohithgc added Area:RM RM task team Task:AzureCLI Area:RM, Owners: @rvairavelu @manolerazvan labels Sep 13, 2023

merlynomsft added a commit that referenced this pull request Sep 28, 2023

Revert "Adding http proxy environment variables to Azure CLIV2 (#18295)"

641738a

This reverts commit d2cd595.

merlynomsft mentioned this pull request Sep 28, 2023

Revert "Adding http proxy environment variables to Azure CLI V2" #19043

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding http proxy environment variables to Azure CLI V2 #18295

Adding http proxy environment variables to Azure CLI V2 #18295

ycamargo commented May 16, 2023

ycamargo commented May 16, 2023

ycamargo commented Jul 27, 2023

v-mohithgc commented Jul 28, 2023

azure-pipelines bot commented Jul 28, 2023

ycamargo commented Jul 28, 2023

azure-pipelines bot commented Jul 28, 2023

v-mohithgc commented Jul 28, 2023

v-mohithgc commented Jul 28, 2023 •

edited

Loading

ycamargo commented Jul 28, 2023

v-mohithgc commented Jul 28, 2023

azure-pipelines bot commented Jul 28, 2023

v-mohithgc commented Sep 6, 2023

azure-pipelines bot commented Sep 6, 2023

kirill-ivlev commented Sep 6, 2023 •

edited

Loading

azure-pipelines bot commented Sep 6, 2023

azure-pipelines bot commented Sep 6, 2023

v-mohithgc commented Sep 8, 2023

azure-pipelines bot commented Sep 8, 2023

v-mohithgc commented Sep 11, 2023

azure-pipelines bot commented Sep 11, 2023

v-mohithgc commented Sep 11, 2023

azure-pipelines bot commented Sep 11, 2023

v-mohithgc commented Sep 12, 2023

azure-pipelines bot commented Sep 12, 2023

v-mohithgc commented Sep 12, 2023

azure-pipelines bot commented Sep 12, 2023

v-mohithgc commented Sep 12, 2023

azure-pipelines bot commented Sep 12, 2023

Adding http proxy environment variables to Azure CLI V2 #18295

Adding http proxy environment variables to Azure CLI V2 #18295

Conversation

ycamargo commented May 16, 2023

ycamargo commented May 16, 2023

ycamargo commented Jul 27, 2023

v-mohithgc commented Jul 28, 2023

azure-pipelines bot commented Jul 28, 2023

ycamargo commented Jul 28, 2023

azure-pipelines bot commented Jul 28, 2023

v-mohithgc commented Jul 28, 2023

v-mohithgc commented Jul 28, 2023 • edited Loading

ycamargo commented Jul 28, 2023

v-mohithgc commented Jul 28, 2023

azure-pipelines bot commented Jul 28, 2023

v-mohithgc commented Sep 6, 2023

azure-pipelines bot commented Sep 6, 2023

kirill-ivlev commented Sep 6, 2023 • edited Loading

azure-pipelines bot commented Sep 6, 2023

azure-pipelines bot commented Sep 6, 2023

v-mohithgc commented Sep 8, 2023

azure-pipelines bot commented Sep 8, 2023

v-mohithgc commented Sep 11, 2023

azure-pipelines bot commented Sep 11, 2023

v-mohithgc commented Sep 11, 2023

azure-pipelines bot commented Sep 11, 2023

v-mohithgc commented Sep 12, 2023

azure-pipelines bot commented Sep 12, 2023

v-mohithgc commented Sep 12, 2023

azure-pipelines bot commented Sep 12, 2023

v-mohithgc commented Sep 12, 2023

azure-pipelines bot commented Sep 12, 2023

v-mohithgc commented Jul 28, 2023 •

edited

Loading

kirill-ivlev commented Sep 6, 2023 •

edited

Loading