Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added date to deprecation warnings for DownloadPackageV0, NuGetInstallerV0, and NuGetRestoreV1 #19078

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

amp-powell
Copy link
Contributor

@amp-powell amp-powell commented Oct 6, 2023

Added date to deprecation warnings for DownloadPackageV0, NuGetInstallerV0, and NuGetRestoreV1

Task name: DownloadPackageV0, NuGetInstallerV0, and NuGetRestoreV1

Description: Added date of when builds will break to deprecation warnings

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) Y - changed NuGetInstallerV0 L0 tests to accept new deprecation warning

Attached related issue: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@amp-powell amp-powell requested a review from a team as a code owner October 6, 2023 23:35
@Saibamen
Copy link

Saibamen commented Oct 7, 2023

Can you link the documentation where the date is from?

@amp-powell
Copy link
Contributor Author

Can you link the documentation where the date is from?

I discussed a deprecation timeline with a PM last week, and we are planning to break builds after 11/27/23 and remove functionality after 1/16/24

Tasks/DownloadPackageV0/download.ts Outdated Show resolved Hide resolved
Tasks/NuGetInstallerV0/nugetinstaller.ts Outdated Show resolved Hide resolved
Tasks/NuGetRestoreV1/nugetinstaller.ts Outdated Show resolved Hide resolved
@amp-powell amp-powell merged commit 4a4464b into master Oct 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants