Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added date to deprecation warnings for DownloadPackageV0, NuGetInstallerV0, and NuGetRestoreV1 #19078

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Added date to deprecation warnings for DownloadPackageV0, NuGetInstallerV0, and NuGetRestoreV1 #19078

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c184026
Added date to deprecation warnings for DownloadPackageV0, NuGetInstal…
Oct 6, 2023
034e3d2
Modified L0 tests to accept new deprecation message
Oct 9, 2023
e317acc
Added removalDate and updated patches
Oct 9, 2023
2e954cb
Merge branch 'master' into users/abpowell/deprecation-warning-with-date
amp-powell Oct 9, 2023
ee586fb
Reverted changes to DownloadPackageV0's package-lock.json file
Oct 10, 2023
636bf46
Merge branch 'users/abpowell/deprecation-warning-with-date' of https:…
Oct 10, 2023
79ba718
Merge branch 'master' into users/abpowell/deprecation-warning-with-date
amp-powell Oct 10, 2023
f48686b
Clearer deprecation message
Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tasks/DownloadPackageV0/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { WebApi } from 'azure-devops-node-api';
tl.setResourcePath(path.join(__dirname, 'task.json'));

async function main(): Promise<void> {
tl.warning("This task will be deprecated soon. Please switch to using DownloadPackage@1");
tl.warning("This task is being deprecated. All builds will break by 11-27-2023. Please switch to using DownloadPackage@1 as soon as possible.");
amp-powell marked this conversation as resolved.
Show resolved Hide resolved
var feed = getProjectAndFeedIdFromInputParam("feed");
if(feed.projectId) {
throw new Error(tl.loc("UnsupportedProjectScopedFeeds"));
Expand Down
4 changes: 2 additions & 2 deletions Tasks/DownloadPackageV0/package-lock.json
View file
Open in desktop
amp-powell marked this conversation as resolved.
Show resolved Hide resolved

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Tasks/DownloadPackageV0/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
"version": {
"Major": 0,
"Minor": 229,
"Patch": 1
"Patch": 2
},
"demands": [],
"minimumAgentVersion": "2.144.0",
"deprecated": true,
"removalDate": "2024-04-22",
"removalDate": "2023-11-27",
"inputs": [
{
"name": "feed",
Expand Down
4 changes: 2 additions & 2 deletions Tasks/DownloadPackageV0/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
"version": {
"Major": 0,
"Minor": 229,
"Patch": 1
"Patch": 2
},
"demands": [],
"minimumAgentVersion": "2.144.0",
"deprecated": true,
"removalDate": "2024-04-22",
"removalDate": "2023-11-27",
"inputs": [
{
"name": "feed",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/NuGetInstallerV0/Tests/L0.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('NuGetInstaller Suite', function () {
assert(tr.stdout.indexOf('credProviderPath = ') >= 0, "should have found credential provider path");
assert(tr.succeeded, 'should have succeeded');
assert(tr.invokedToolCount == 1, 'should have run NuGet');
assert.equal(tr.warningIssues[0], 'This task will be deprecated soon', "should have deprecation warning");
assert.equal(tr.warningIssues[0], "This task is being deprecated. All builds will break by 11-27-2023. Please switch to using NuGetCommand@2's 'restore' option as soon as possible.", "should have deprecation warning");
assert.equal(tr.errorIssues.length, 0, "should have no errors");
done();
}).timeout(20000);
Expand Down
2 changes: 1 addition & 1 deletion Tasks/NuGetInstallerV0/nugetinstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class RestoreOptions implements INuGetCommandOptions {
}

async function main(): Promise<void> {
tl.warning("This task will be deprecated soon");
tl.warning("This task is being deprecated. All builds will break by 11-27-2023. Please switch to using NuGetCommand@2's 'restore' option as soon as possible.");
amp-powell marked this conversation as resolved.
Show resolved Hide resolved
let packagingLocation: pkgLocationUtils.PackagingLocation;
try {
packagingLocation = await pkgLocationUtils.getPackagingUris(pkgLocationUtils.ProtocolType.NuGet);
Expand Down
4 changes: 2 additions & 2 deletions Tasks/NuGetInstallerV0/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"version": {
"Major": 0,
"Minor": 229,
"Patch": 0
"Patch": 1
},
"runsOn": [
"Agent",
"DeploymentGroup"
],
"minimumAgentVersion": "2.115.0",
"deprecated": true,
"removalDate": "2024-04-22",
"removalDate": "2023-11-27",
"groups": [
{
"name": "advanced",
Expand Down
4 changes: 2 additions & 2 deletions Tasks/NuGetInstallerV0/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"version": {
"Major": 0,
"Minor": 229,
"Patch": 0
"Patch": 1
},
"runsOn": [
"Agent",
"DeploymentGroup"
],
"minimumAgentVersion": "2.115.0",
"deprecated": true,
"removalDate": "2024-04-22",
"removalDate": "2023-11-27",
"groups": [
{
"name": "advanced",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/NuGetRestoreV1/nugetinstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class RestoreOptions implements INuGetCommandOptions {
}

async function main(): Promise<void> {
tl.warning("This task will be deprecated soon. Please switch to using NuGetCommand@2's 'restore' option");
tl.warning("This task is being deprecated. All builds will break by 11-27-2023. Please switch to using NuGetCommand@2's 'restore' option as soon as possible.");
amp-powell marked this conversation as resolved.
Show resolved Hide resolved
let packagingLocation: pkgLocationUtils.PackagingLocation;
try {
tl.debug("getting the uris");
Expand Down
4 changes: 2 additions & 2 deletions Tasks/NuGetRestoreV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"version": {
"Major": 1,
"Minor": 229,
"Patch": 3
"Patch": 4
},
"runsOn": [
"Agent",
"DeploymentGroup"
],
"minimumAgentVersion": "2.144.0",
"deprecated": true,
"removalDate": "2024-04-22",
"removalDate": "2023-11-27",
"groups": [
{
"name": "advanced",
Expand Down
4 changes: 2 additions & 2 deletions Tasks/NuGetRestoreV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
"version": {
"Major": 1,
"Minor": 229,
"Patch": 3
"Patch": 4
},
"runsOn": [
"Agent",
"DeploymentGroup"
],
"minimumAgentVersion": "2.144.0",
"deprecated": true,
"removalDate": "2024-04-22",
"removalDate": "2023-11-27",
"groups": [
{
"name": "advanced",
Expand Down