AzureRMWebAppTask migrated to nodejs #2506

Ajay-MS · 2016-09-14T06:26:02Z

Merging rmmaster2 to master

… users/vinca/MigrateToNode

* Removing PS Fies * Added support for folder and optinal parameters.xml in package * Changes after conflicts * Indentation changes * correction * Indentation correction * Corrected review comments

Changed Request to HttpClient

Azure RM Upgrade scenario handling in task

SetParamFile issue fix

#2451) * Conditional selection of deployment tool and check for param file on linux plat * PR review correction and few fixes for linux agent. * check of Parameter.xml

Task upgrade fix for not reading right inputs

* Path with '&' issue Fix * Using Local MSDeploy Fix * Resource File Updated * L0 Tests Updated (Ashish) * Gulp Test Fix * TypoError Fix

…ixes Reverting compact changes handling in UI

mvvsubbu · 2016-09-19T07:03:57Z

Tasks/AzureRmWebAppDeployment/task.json

@@ -1,8 +1,8 @@
 {
    "id": "497D490F-EEA7-4F2B-AB94-48D9C1ACDCB1",
    "name": "AzureRMWebAppDeployment",


Do sit with PM once and get final help markdowns scrubbed

mvvsubbu

Looks fine

mvvsubbu · 2016-09-19T07:21:35Z

Tasks/AzureRmWebAppDeployment/AzureRmWebAppDeployment.ts

+        }
+
+        if(canUseWebDeploy(useWebDeploy)) {        
+           tl._writeLine("##vso[task.setvariable variable=websitePassword;issecret=true;]" + publishingProfile.userPWD);


Mask user id as well

mvvsubbu · 2016-09-19T07:22:45Z

Tasks/AzureRmWebAppDeployment/AzureRmWebAppDeployment.ts

+    }
+    finally {
+        if(!isDeploymentSuccess) {
+            throw Error(deploymentError);


Move this code out of finally block as this not at all related to previous try/catch

mvvsubbu · 2016-09-19T07:23:01Z

Tasks/AzureRmWebAppDeployment/AzureRmWebAppDeployment.ts

+    }
+    finally {
+        if(!isDeploymentSuccess) {
+            throw Error(deploymentError);


Move this code out of finally block as this not at all related to previous try/catch

mvvsubbu · 2016-09-19T07:23:49Z

Tasks/AzureRmWebAppDeployment/AzureRmWebAppDeployment.ts

+function fileExists(path): boolean {
+  try  {
+    return tl.stats(path).isFile();
+  }


Post this review can you add this function in vsts-task-lib as well

Will do it.

mvvsubbu · 2016-09-19T07:29:00Z

Tasks/AzureRmWebAppDeployment/AzureRMUtil.ts

+    return requestDetails;
+}
+
+async function getWebAppPublishProfile(SPN, webAppName: string, resourceGroupName: string, deployToSlotFlag: boolean, slotName: string ) {


This is not required to be separate function merge both functions

RoopeshNair · 2016-09-19T11:26:55Z

Tasks/AzureRmWebAppDeployment/task.json

            "name": "Package",
            "type": "filePath",
-            "label": "Package",
+            "label": "Package or Folder",
            "defaultValue": "",
            "required": true,
            "helpMarkDown": "Location of the Web App zip package on the automation agent or on a UNC path accessible to the automation agent like, \\\\\\\\BudgetIT\\Web\\Deploy\\Fabrikam.zip. Predefined system variables and wild cards like, $(System.DefaultWorkingDirectory)\\\\***.zip` can be also used here."


Folder or file path to the Web App package. Variables (Build | Release), wild cards are supported.

For example, $(System.DefaultWorkingDirectory)\***.zip

RoopeshNair · 2016-09-19T11:27:41Z

Tasks/AzureRmWebAppDeployment/task.json

            "defaultValue": "",
            "required": true,
            "helpMarkDown": "Location of the Web App zip package on the automation agent or on a UNC path accessible to the automation agent like, \\\\\\\\BudgetIT\\Web\\Deploy\\Fabrikam.zip. Predefined system variables and wild cards like, $(System.DefaultWorkingDirectory)\\\\***.zip` can be also used here."
        },
        {
+            "name": "WebAppUri",
+            "type": "string",
+            "label": "Web App Hosted Url",


Remove Hosted, the text would just be "Web App URL"

RoopeshNair · 2016-09-19T11:35:20Z

Tasks/AzureRmWebAppDeployment/task.json

+            "required": false,
+            "defaultValue": "",
+            "groupName": "output",
+            "helpMarkDown": "Provide a name for the variable for the webapp hosted url. The variable can be used as $(variableName) to refer to the hosted url of webapp in subsequent tasks like in the PowerShell on Target Machines task."


Specify a name for the output variable that is generated for the URL of the Web App. The variable can be consumed in subsequent tasks.

RoopeshNair · 2016-09-19T11:47:27Z

Tasks/AzureRmWebAppDeployment/task.json

+            "required": false,
+            "defaultValue": "true",
+            "groupName": "AdditionalDeploymentOptions",
+            "helpMarkDown": "The Web Deploy options will only work when the automation agent is on Windows and will be ignored on Linux. The options are also ignored for file formats that are not zipped or in a  folders, like Java WAR files. FTP works with automation agent on both Windows and Linux and for zip files, folders, and Java WAR files."


"Publish using web deploy options are supported only when using Windows agent. On other platforms, the task relies on Kudu REST APIs (https://github.com/projectkudu/kudu/wiki/REST-API) to deploy the Web App, and following options are not supported"

* Migrating from Powershell to Node.js * Made Change to Friendly Name * Additional Changes * Additional Changes * Made changes to RMUtil * Made change to Rest Call * Added Q * Added Q Library * Rearranged module headers * Made changes to task.json * Redefining error message * Removing PS Files * MSDEPloyexePath Function added * MSDEPloyexePath Function added * Changed then with await, package.json updated * Removing .taskkey * Run MSDeploycommand function updated * Async await changes * Handling files with spaces * CheckFile Function added * Fix for task not failing in case of error * Fixed review comments * Destination output url Fix * Publishing profile Fix * SetParamFile find Fix * SetParam File Fix * File supplied Fix * Fixing few formatting issues * Users/ajya/node js folder support to task (#2328) * Removing PS Fies * Added support for folder and optinal parameters.xml in package * Changes after conflicts * Indentation changes * correction * Indentation correction * Corrected review comments * PR Review Fix (MSDeploy return code Fix) * Added WebDeploy Function * Added Comments at Method Level * AzureRMUtil Update Deployment History Fix * Fixing Formatting issues * Destination URL Fix * common part moved to main * Deployment of webapplication using KUDU service * Indentation correction of deferred statement * added messages that will be help for debugging. * Adding unit test for AzureRMWebAppDeployment Task (#2386) * Adding unit test for AzureRMWebAppDeployment Task * Made changes according to PR comments * Made changes according to PR comments * Azure RM Upgrade scenario handling in task * Review comment fixes * Changed Request to HttpClient * Changes Reqyest to HttpClient * Changed Error to defer(reject) * Changed tl to defer(resolve) * SetParamFile issue fix * msDepoyBatchFIle Path FIx * Conditional selection of deployment tool and check for param file on … (#2451) * Conditional selection of deployment tool and check for param file on linux plat * PR review correction and few fixes for linux agent. * check of Parameter.xml * Added unit test (#2444) * Task upgrade fix for not reading right inputs * Reverting compact changes handling in UI * Path Issue & Bug Bash Fix (#2512) * Path with '&' issue Fix * Using Local MSDeploy Fix * Resource File Updated * L0 Tests Updated (Ashish) * Gulp Test Fix * TypoError Fix * enabling appoffline feature by default (#2555) * Parameter Content Fix (#2557) * Help mark down corrected

* AzureRMWebAppTask migrated to nodejs (#2506) * Migrating from Powershell to Node.js * Made Change to Friendly Name * Additional Changes * Additional Changes * Made changes to RMUtil * Made change to Rest Call * Added Q * Added Q Library * Rearranged module headers * Made changes to task.json * Redefining error message * Removing PS Files * MSDEPloyexePath Function added * MSDEPloyexePath Function added * Changed then with await, package.json updated * Removing .taskkey * Run MSDeploycommand function updated * Async await changes * Handling files with spaces * CheckFile Function added * Fix for task not failing in case of error * Fixed review comments * Destination output url Fix * Publishing profile Fix * SetParamFile find Fix * SetParam File Fix * File supplied Fix * Fixing few formatting issues * Users/ajya/node js folder support to task (#2328) * Removing PS Fies * Added support for folder and optinal parameters.xml in package * Changes after conflicts * Indentation changes * correction * Indentation correction * Corrected review comments * PR Review Fix (MSDeploy return code Fix) * Added WebDeploy Function * Added Comments at Method Level * AzureRMUtil Update Deployment History Fix * Fixing Formatting issues * Destination URL Fix * common part moved to main * Deployment of webapplication using KUDU service * Indentation correction of deferred statement * added messages that will be help for debugging. * Adding unit test for AzureRMWebAppDeployment Task (#2386) * Adding unit test for AzureRMWebAppDeployment Task * Made changes according to PR comments * Made changes according to PR comments * Azure RM Upgrade scenario handling in task * Review comment fixes * Changed Request to HttpClient * Changes Reqyest to HttpClient * Changed Error to defer(reject) * Changed tl to defer(resolve) * SetParamFile issue fix * msDepoyBatchFIle Path FIx * Conditional selection of deployment tool and check for param file on … (#2451) * Conditional selection of deployment tool and check for param file on linux plat * PR review correction and few fixes for linux agent. * check of Parameter.xml * Added unit test (#2444) * Task upgrade fix for not reading right inputs * Reverting compact changes handling in UI * Path Issue & Bug Bash Fix (#2512) * Path with '&' issue Fix * Using Local MSDeploy Fix * Resource File Updated * L0 Tests Updated (Ashish) * Gulp Test Fix * TypoError Fix * enabling appoffline feature by default (#2555) * Parameter Content Fix (#2557) * Help mark down corrected * renamed files to lowercase case (#2560) * renamed files to lowercase case * PR comment pending changes * Path Regex Fix (#2571) * Users/ajya/option depn fix reg edit (#2586) * replaced regedit with winreg * converted case to small case * reverting app offline flag value * renamed method * changed logic for gettting latest version * Revert changes for regedit * optional dependency

vincent1173 and others added 30 commits August 11, 2016 21:06

Migrating from Powershell to Node.js

5c87a1c

Made Change to Friendly Name

fa03c87

Additional Changes

28e9932

Additional Changes

8656196

Made changes to RMUtil

f704897

Merge branch 'master' of https://github.com/Microsoft/vsts-tasks into…

b703fef

… users/vinca/MigrateToNode

Made change to Rest Call

2aeb4cb

Added Q

88bd1e0

Added Q Library

3f2fc9e

Rearranged module headers

2165c5c

Made changes to task.json

0a879a2

Redefining error message

9ad95f3

Removing PS Files

6d5f42e

MSDEPloyexePath Function added

857b167

MSDEPloyexePath Function added

74c50bc

Changed then with await, package.json updated

93f9a5e

Removing .taskkey

f5ca7e1

Run MSDeploycommand function updated

a9f58b9

Async await changes

811338a

Handling files with spaces

b835158

CheckFile Function added

b6f3080

Fix for task not failing in case of error

f28dd86

Fixed review comments

8164962

Destination output url Fix

6905985

Publishing profile Fix

a435918

SetParamFile find Fix

e7d9a4f

SetParam File Fix

66fb795

File supplied Fix

f697987

Fixing few formatting issues

9151d36

Users/ajya/node js folder support to task (#2328)

2fc7486

* Removing PS Fies * Added support for folder and optinal parameters.xml in package * Changes after conflicts * Indentation changes * correction * Indentation correction * Corrected review comments

vincent1173 and others added 11 commits September 8, 2016 12:11

Changes Reqyest to HttpClient

dd8efd8

Changed Error to defer(reject)

21e4d3d

Changed tl to defer(resolve)

9aa3e20

SetParamFile issue fix

ad36411

Merge pull request #2442 from Microsoft/users/vinca/AzureRestCall

af3d0cb

Changed Request to HttpClient

Merge pull request #2396 from Microsoft/users/subraman/azurermupgradefix

fc2c47f

Azure RM Upgrade scenario handling in task

msDepoyBatchFIle Path FIx

db7590f

Merge pull request #2452 from Microsoft/users/vinca/setParameterFix

8f8a430

SetParamFile issue fix

Conditional selection of deployment tool and check for param file on … (

d47e9f4

#2451) * Conditional selection of deployment tool and check for param file on linux plat * PR review correction and few fixes for linux agent. * check of Parameter.xml

Added unit test (#2444)

f9a492a

resolving merge conflicts

2e08efa

msftclas added the cla-not-required label Sep 14, 2016

mvvsubbu and others added 6 commits September 15, 2016 20:49

Task upgrade fix for not reading right inputs

af472f7

Merge pull request #2532 from Microsoft/users/subraman/upgradebugfixes

a9c9467

Task upgrade fix for not reading right inputs

Reverting compact changes handling in UI

d821050

Path Issue & Bug Bash Fix (#2512)

f7f416c

* Path with '&' issue Fix * Using Local MSDeploy Fix * Resource File Updated * L0 Tests Updated (Ashish) * Gulp Test Fix * TypoError Fix

Merge pull request #2542 from Microsoft/users/subraman/revertupgradef…

27af6ce

…ixes Reverting compact changes handling in UI

enabling appoffline feature by default (#2555)

3a9d7e2

mvvsubbu reviewed Sep 19, 2016

View reviewed changes

mvvsubbu approved these changes Sep 19, 2016

View reviewed changes

RoopeshNair reviewed Sep 19, 2016

View reviewed changes

vincent1173 and others added 2 commits September 19, 2016 17:42

Parameter Content Fix (#2557)

38fc110

Help mark down corrected

d08a528

Ajay-MS merged commit 7b4575c into master Sep 19, 2016

bryanmacfarlane deleted the features/rmmaster2 branch October 20, 2016 02:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AzureRMWebAppTask migrated to nodejs #2506

AzureRMWebAppTask migrated to nodejs #2506

Ajay-MS commented Sep 14, 2016

mvvsubbu Sep 19, 2016

Ajay-MS Sep 19, 2016

mvvsubbu left a comment

mvvsubbu Sep 19, 2016

Ajay-MS Sep 19, 2016

mvvsubbu Sep 19, 2016

Ajay-MS Sep 19, 2016

mvvsubbu Sep 19, 2016

Ajay-MS Sep 19, 2016

mvvsubbu Sep 19, 2016

Ajay-MS Sep 19, 2016

mvvsubbu Sep 19, 2016

Ajay-MS Sep 19, 2016

RoopeshNair Sep 19, 2016

RoopeshNair Sep 19, 2016

RoopeshNair Sep 19, 2016

RoopeshNair Sep 19, 2016

AzureRMWebAppTask migrated to nodejs #2506

AzureRMWebAppTask migrated to nodejs #2506

Conversation

Ajay-MS commented Sep 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mvvsubbu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment