Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Content Fix #2557

Merged
merged 2 commits into from Sep 19, 2016
Merged

Conversation

vincent1173
Copy link
Contributor

No description provided.

Copy link

@Ajay-MS Ajay-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.

@vincent1173 vincent1173 merged commit 38fc110 into features/rmmaster2 Sep 19, 2016
Ajay-MS pushed a commit that referenced this pull request Sep 19, 2016
* Migrating from Powershell to Node.js

* Made Change to Friendly Name

* Additional Changes

* Additional Changes

* Made changes to RMUtil

* Made change to Rest Call

* Added Q

* Added Q Library

* Rearranged module headers

* Made changes to task.json

* Redefining error message

* Removing PS Files

* MSDEPloyexePath Function added

* MSDEPloyexePath Function added

* Changed then with await, package.json updated

* Removing .taskkey

* Run MSDeploycommand function updated

* Async await changes

* Handling files with spaces

* CheckFile Function added

* Fix for task not failing in case of error

* Fixed review comments

* Destination output url Fix

* Publishing profile Fix

* SetParamFile find Fix

* SetParam File Fix

* File supplied Fix

* Fixing few formatting issues

* Users/ajya/node js folder support to task (#2328)

* Removing PS Fies

* Added support for folder and optinal parameters.xml in package

* Changes after conflicts

* Indentation changes

* correction

* Indentation correction

* Corrected review comments

* PR Review Fix (MSDeploy return code Fix)

* Added WebDeploy Function

* Added Comments at Method Level

* AzureRMUtil Update Deployment History Fix

* Fixing Formatting issues

* Destination URL Fix

* common part moved to main

* Deployment of webapplication using KUDU service

* Indentation correction of deferred statement

* added messages that will be help for debugging.

* Adding unit test for AzureRMWebAppDeployment Task (#2386)

* Adding unit test for AzureRMWebAppDeployment Task

* Made changes according to PR comments

* Made changes according to PR comments

* Azure RM Upgrade scenario handling in task

* Review comment fixes

* Changed Request to HttpClient

* Changes Reqyest to HttpClient

* Changed Error to defer(reject)

* Changed tl to defer(resolve)

* SetParamFile issue fix

* msDepoyBatchFIle Path FIx

* Conditional selection of deployment tool and check for param file on … (#2451)

* Conditional selection of deployment tool and check for param file on linux plat

* PR review correction and few fixes for linux agent.

* check of Parameter.xml

* Added unit test (#2444)

* Task upgrade fix for not reading right inputs

* Reverting compact changes handling in UI

* Path Issue & Bug Bash Fix (#2512)

* Path with '&' issue Fix

* Using Local MSDeploy Fix

* Resource File Updated

* L0 Tests Updated (Ashish)

* Gulp Test Fix

* TypoError Fix

* enabling appoffline feature by default (#2555)

* Parameter Content Fix (#2557)

* Help mark down corrected
Ajay-MS pushed a commit that referenced this pull request Sep 19, 2016
* Migrating from Powershell to Node.js

* Made Change to Friendly Name

* Additional Changes

* Additional Changes

* Made changes to RMUtil

* Made change to Rest Call

* Added Q

* Added Q Library

* Rearranged module headers

* Made changes to task.json

* Redefining error message

* Removing PS Files

* MSDEPloyexePath Function added

* MSDEPloyexePath Function added

* Changed then with await, package.json updated

* Removing .taskkey

* Run MSDeploycommand function updated

* Async await changes

* Handling files with spaces

* CheckFile Function added

* Fix for task not failing in case of error

* Fixed review comments

* Destination output url Fix

* Publishing profile Fix

* SetParamFile find Fix

* SetParam File Fix

* File supplied Fix

* Fixing few formatting issues

* Users/ajya/node js folder support to task (#2328)

* Removing PS Fies

* Added support for folder and optinal parameters.xml in package

* Changes after conflicts

* Indentation changes

* correction

* Indentation correction

* Corrected review comments

* PR Review Fix (MSDeploy return code Fix)

* Added WebDeploy Function

* Added Comments at Method Level

* AzureRMUtil Update Deployment History Fix

* Fixing Formatting issues

* Destination URL Fix

* common part moved to main

* Deployment of webapplication using KUDU service

* Indentation correction of deferred statement

* added messages that will be help for debugging.

* Adding unit test for AzureRMWebAppDeployment Task (#2386)

* Adding unit test for AzureRMWebAppDeployment Task

* Made changes according to PR comments

* Made changes according to PR comments

* Azure RM Upgrade scenario handling in task

* Review comment fixes

* Changed Request to HttpClient

* Changes Reqyest to HttpClient

* Changed Error to defer(reject)

* Changed tl to defer(resolve)

* SetParamFile issue fix

* msDepoyBatchFIle Path FIx

* Conditional selection of deployment tool and check for param file on … (#2451)

* Conditional selection of deployment tool and check for param file on linux plat

* PR review correction and few fixes for linux agent.

* check of Parameter.xml

* Added unit test (#2444)

* Task upgrade fix for not reading right inputs

* Reverting compact changes handling in UI

* Path Issue & Bug Bash Fix (#2512)

* Path with '&' issue Fix

* Using Local MSDeploy Fix

* Resource File Updated

* L0 Tests Updated (Ashish)

* Gulp Test Fix

* TypoError Fix

* enabling appoffline feature by default (#2555)

* Parameter Content Fix (#2557)

* Help mark down corrected
Ajay-MS pushed a commit that referenced this pull request Sep 21, 2016
* AzureRMWebAppTask migrated to nodejs (#2506)

* Migrating from Powershell to Node.js

* Made Change to Friendly Name

* Additional Changes

* Additional Changes

* Made changes to RMUtil

* Made change to Rest Call

* Added Q

* Added Q Library

* Rearranged module headers

* Made changes to task.json

* Redefining error message

* Removing PS Files

* MSDEPloyexePath Function added

* MSDEPloyexePath Function added

* Changed then with await, package.json updated

* Removing .taskkey

* Run MSDeploycommand function updated

* Async await changes

* Handling files with spaces

* CheckFile Function added

* Fix for task not failing in case of error

* Fixed review comments

* Destination output url Fix

* Publishing profile Fix

* SetParamFile find Fix

* SetParam File Fix

* File supplied Fix

* Fixing few formatting issues

* Users/ajya/node js folder support to task (#2328)

* Removing PS Fies

* Added support for folder and optinal parameters.xml in package

* Changes after conflicts

* Indentation changes

* correction

* Indentation correction

* Corrected review comments

* PR Review Fix (MSDeploy return code Fix)

* Added WebDeploy Function

* Added Comments at Method Level

* AzureRMUtil Update Deployment History Fix

* Fixing Formatting issues

* Destination URL Fix

* common part moved to main

* Deployment of webapplication using KUDU service

* Indentation correction of deferred statement

* added messages that will be help for debugging.

* Adding unit test for AzureRMWebAppDeployment Task (#2386)

* Adding unit test for AzureRMWebAppDeployment Task

* Made changes according to PR comments

* Made changes according to PR comments

* Azure RM Upgrade scenario handling in task

* Review comment fixes

* Changed Request to HttpClient

* Changes Reqyest to HttpClient

* Changed Error to defer(reject)

* Changed tl to defer(resolve)

* SetParamFile issue fix

* msDepoyBatchFIle Path FIx

* Conditional selection of deployment tool and check for param file on … (#2451)

* Conditional selection of deployment tool and check for param file on linux plat

* PR review correction and few fixes for linux agent.

* check of Parameter.xml

* Added unit test (#2444)

* Task upgrade fix for not reading right inputs

* Reverting compact changes handling in UI

* Path Issue & Bug Bash Fix (#2512)

* Path with '&' issue Fix

* Using Local MSDeploy Fix

* Resource File Updated

* L0 Tests Updated (Ashish)

* Gulp Test Fix

* TypoError Fix

* enabling appoffline feature by default (#2555)

* Parameter Content Fix (#2557)

* Help mark down corrected

* renamed files to lowercase case (#2560)

* renamed files to lowercase case

* PR comment pending changes

* Path Regex Fix (#2571)

* Users/ajya/option depn fix reg edit (#2586)

* replaced regedit with winreg

* converted case to small case

* reverting app offline flag value

* renamed method

* changed logic for gettting latest version

* Revert changes for regedit

* optional dependency
@bryanmacfarlane bryanmacfarlane deleted the users/vinca/ParamFileFix branch October 20, 2016 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants