feature: add Workspace param to AzureQuantumProvider and AzureQuantumService + Q# upgrade #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikomiss
commented
Dec 15, 2023
xinyi-joffre
approved these changes
Jan 3, 2024
xinyi-joffre
approved these changes
Jan 3, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -182,6 +185,10 @@ | |||
| input_data_format = kwargs.pop("input_data_format", "qir.v1") | |||
| output_data_format = kwargs.pop("output_data_format", self._qir_output_data_format()) | |||
| content_type = kwargs.pop("content_type", "qir.v1") | |||
| # setting UserAgent header to indicate Q# submission | |||
| # TODO: this is a temporary solution. We should be setting the User-Agent header | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
xinyi-joffre
approved these changes
Jan 9, 2024
|
|
||
| # Also add all possible shots options into input_params to make sure | ||
| # that all backends covered. | ||
| # TODO: Double check all backends for shots options in order to remove this extra check. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
…Service + Q# lang
…object (#542) * Introduce the "shots" parameter to 'sumbit' function of the 'Target' object * Remove num_shots from kwargs. * Add warning on passing shots for estimator * Add 'shots' option for qiskit backends. * Refactor target shots option * The num_shots option for a target class now is checked by a helper function. * New warning is printed on passing shots and num_shots together. * Allow provider-specific shots options. * Fix pascal target * add tests. * Add back all possible shots params --------- Co-authored-by: ArturKamalov <v-akamalov@microsoft.com> Co-authored-by: kikomiss <144282031+kikomiss@users.noreply.github.com>
* Remove aio modules. --------- Co-authored-by: ArturKamalov <v-akamalov@microsoft.com> Co-authored-by: kikomiss <144282031+kikomiss@users.noreply.github.com> Co-authored-by: Kirill Komissarov <kikomiss@microsoft.com>
* Add warning when not using shots parameter. * chore: changed warning verbiage + added missing test recordings --------- Co-authored-by: ArturKamalov <v-akamalov@microsoft.com> Co-authored-by: Kirill Komissarov <kikomiss@microsoft.com>
kikomiss
force-pushed
the
users/kikomiss/features/qiskit-cirq-init-with-workspace-and-qsharp-lang
branch
from
620120f
to
1bb1d96
Compare
xinyi-joffre
approved these changes
Jan 11, 2024
kikomiss
changed the title
xinyi-joffre
approved these changes
Jan 12, 2024
kikomiss
deleted the
users/kikomiss/features/qiskit-cirq-init-with-workspace-and-qsharp-lang
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
AzureQuantumProviderandAzureQuantumServicewithresouce_idandlocationparameters.microsoft.quantum-results.v1job output formatshotsparameter to Qiskit'sbackend.run(), Passthrough'starget.submit()and toestimate_cost()to unify user-experience across backendsazure.quantum.aiomodule