Changes for Issue #59, #63 and #64 (#70)

Co-authored-by: Vishal Kalal <vishal.rajasthan@gmail.com>
microsoft · Jan 29, 2024 · 5cc5c3e · 5cc5c3e
1 parent fc5a4ee
commit 5cc5c3e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/main.bicep b/main.bicep
@@ -357,7 +357,7 @@ module webAppModule './modules/webapp/main.bicep' = {
     // TODO: Consider deploying as P0V3 to ensure the deployment runs on a scale unit that supports P_v3 for future upgrades. GH issue #50
     skuName: 'S1'
     skuTier: 'Standard'
-    peSubnetId: virtualNetworkModule.outputs.subnets.ComputeSubnet.id
+    peSubnetId: virtualNetworkModule.outputs.subnets.PrivateLinkSubnet.id
     appInsights_connectionString: monitoring.outputs.appInsightsResourceId
     appInsights_instrumentationKey: monitoring.outputs.appInsightsInstrumentationKey
     linuxFxVersion: 'php|8.2'

diff --git a/modules/storage/storage.bicep b/modules/storage/storage.bicep
@@ -17,6 +17,7 @@ param keyVaultSecretName string
 param tags object
 param deploymentNameStructure string
 param kind string
+param minTlsVersion string = 'TLS1_2'
 
 var storageType = kind == 'FileStorage' ? 'file' : 'blob'
 
@@ -31,6 +32,7 @@ resource storageAccount 'Microsoft.Storage/storageAccounts@2022-09-01' = {
   properties: {
     allowBlobPublicAccess: false
     publicNetworkAccess: 'Disabled'
+    minimumTlsVersion: minTlsVersion
   }
 }
 

diff --git a/modules/webapp/webapp.bicep b/modules/webapp/webapp.bicep
@@ -33,6 +33,7 @@ param appInsights_instrumentationKey string
 param storageAccountKeySecretRef string
 param storageAccountName string
 param storageAccountContainerName string
+param minTlsVersion string = '1.2'
 
 param uamiId string
 
@@ -66,7 +67,7 @@ resource webApp 'Microsoft.Web/sites@2022-03-01' = {
       http20Enabled: true
 
       linuxFxVersion: linuxFxVersion
-      minTlsVersion: '1.2'
+      minTlsVersion: minTlsVersion
       ftpsState: 'FtpsOnly'
       appCommandLine: prerequisiteCommand
       appSettings: [