Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign unins000.exe #24964

Closed
kisantia opened this issue Nov 14, 2023 · 0 comments · Fixed by #25112
Closed

Sign unins000.exe #24964

kisantia opened this issue Nov 14, 2023 · 0 comments · Fixed by #25112
Assignees
@cheenamalhotra
Labels
Approved Area - Shell Bug Triage: Done
Milestone
November 2023 Hot...

Comments

@kisantia
Copy link
Contributor

unins000.exe currently isn't being signed. #24940 added back signing for many of the files, but need to investigate how to unins000.exe since it isn't getting signed during that step.

Should also go through all the files to make sure no others were missed.
@kisantia kisantia added this to the February 2024 Release milestone Nov 14, 2023
@kisantia kisantia mentioned this issue Nov 14, 2023
Closed
@cheenamalhotra cheenamalhotra mentioned this issue Dec 2, 2023
Merged
@cheenamalhotra cheenamalhotra self-assigned this Dec 2, 2023
@cheenamalhotra cheenamalhotra mentioned this issue Dec 11, 2023
Merged
@cheenamalhotra cheenamalhotra linked a pull request Jan 2, 2024 that will close this issue
[Release/1.47] Codesign unis000.exe with ESRP client (#25089) #25112
Merged
@kisantia kisantia closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheenamalhotra cheenamalhotra

Labels
Approved Area - Shell Bug Triage: Done
Projects
ADS Core Committer and Fundamentals
Status: Done
Milestone
November 2023 Hotfix 1
Development

Successfully merging a pull request may close this issue.

[Release/1.47] Codesign unis000.exe with ESRP client (#25089) microsoft/azuredatastudio
4 participants
@kenvanhyning @cheenamalhotra @kisantia @dlevy-msft