Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release/1.47] Codesign unis000.exe with ESRP client (#25089) #25112

Merged
merged 1 commit into from
Jan 5, 2024
Merged

[Release/1.47] Codesign unis000.exe with ESRP client (#25089) #25112

merged 1 commit into from
Jan 5, 2024

Conversation

cheenamalhotra
Copy link
Member

Ports #25089 to release/1.47 branch.
Addresses #24964

@coveralls
Copy link

coveralls commented Dec 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7389268285

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.574%
Totals Coverage Status
Change from base Build 7388916718: 0.0%
Covered Lines: 30787
Relevant Lines: 69355
💛 - Coveralls

kisantia
kisantia approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@kisantia kisantia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These infrastructure ports look good to merge already if all the checks pass on rerun

@cheenamalhotra
Copy link
Member Author

cheenamalhotra commented Dec 13, 2023 •
edited
Loading

These infrastructure ports look good to merge already if all the checks pass on rerun

They're inter-dependent, so you can start by merging the CI Workflow changes first :) #25113

@cheenamalhotra cheenamalhotra linked an issue Jan 2, 2024 that may be closed by this pull request
Sign unins000.exe #24964
Closed
@kisantia kisantia merged commit f38e313 into release/1.47 Jan 5, 2024
10 checks passed
@kisantia kisantia deleted the cheena/1.47-fix-unins branch January 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisantia kisantia kisantia approved these changes

Assignees
No one assigned
Labels
Port Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign unins000.exe
3 participants
@cheenamalhotra @coveralls @kisantia