-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix windows signing #24940
fix windows signing #24940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we should try to do the same thing that VS Code is doing, so I'd be interested to know when they switched over to what they're currently using and why (unless they were using it from the start - and then my question would be why didn't we do the same)
I definitely have some concern that any differences like this could result in similar issues down the line if things are changing again...
Pull Request Test Coverage Report for Build 6827935698
💛 - Coveralls |
yup that's something I'll look more into when I'm DRI next week! |
merging now that windows checks are finished. The mac failure is at the install dependencies step that's been failing intermittently (will investigate more later), but that step is passing in the mac smoke tests check. |
Addresses #24930. This reverts the changes to sql-product-build-win32.yml in #21311. There no longer seems to be the issue with signing failing for
.node
files, and for some reason the minimatch pattern was not finding all the expected files.We'll need to keep an eye on this in case there are signing issues again due to the .node files, but vscode uses a pattern include that includes
*.node
(although using a differen task), so I'm less concerned about that.