Add @ranasaria code reviewer for 3 extensions #12973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding myself as a code reviewer for arc, azdata, and resource-deployment extensions.
Pull Request Test Coverage Report for Build 315951838
💛 - Coveralls |
alanrenmsft
reviewed
Oct 18, 2020
| /src/sql/*.d.ts @alanrenmsft @Charles-Gagnon | ||
| /src/sql/*.d.ts @alanrenmsft @Charles-Gagnon @ranasaria | ||
| /src/extensions/resource-deployment/* @ranasaria | ||
| /src/extensions/arc/ @ranasaria |
There was a problem hiding this comment.
why are there different ways to match files here, resource-deployment has a trailing * but these do not, actually according to the syntax, you don't need that.
There was a problem hiding this comment.
good catch the * is not needed for resource-deployment as that will just match to files directly under resource-deployment
alanrenmsft
approved these changes
Oct 19, 2020
lucyzhang929
pushed a commit
that referenced
this pull request
Oct 20, 2020
* Add @ranasaria code reviewer for 3 extensions Adding myself as a code reviewer for arc, azdata, and resource-deployment extensions. * pr feedback
halerankin
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Add @ranasaria code reviewer for 3 extensions Adding myself as a code reviewer for arc, azdata, and resource-deployment extensions. * pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding myself as a code reviewer for arc, azdata, and resource-deployment extensions.