Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook Views Init Fix #17471

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Notebook Views Init Fix #17471

merged 1 commit into from
Oct 22, 2021

Conversation

dhgrajeda
Copy link
Member

This PR fixes #17061

@dhgrajeda
Notebook Views initialization fix (#17109)
ccc4aa4 
Separate the Views load from the initialization. This way we can load previously created views, and only add the new views data to the document when needed. For now, this happens only when a view is created.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1373978922

  • 33 of 36 (91.67%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 41.509%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sql/workbench/contrib/notebook/browser/notebookEditor.component.ts 0 1 0.0%
src/sql/workbench/services/notebook/browser/notebookViews/notebookViewsExtension.ts 28 30 93.33%
Totals Coverage Status
Change from base Build 1373742832: 0.03%
Covered Lines: 26840
Relevant Lines: 58675
💛 - Coveralls

@chlafreniere chlafreniere merged commit d7283a6 into release/1.33 Oct 22, 2021
@chlafreniere chlafreniere deleted the dhgrajeda/notebookviews-init-fix branch October 22, 2021 22:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlafreniere chlafreniere chlafreniere approved these changes

Assignees
No one assigned
Labels
Port Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhgrajeda @coveralls @chlafreniere