Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env vars being overwritten in ext unit test script #19574

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

Charles-Gagnon
Copy link
Contributor

Env vars such as ADS_TEST_GREP weren't being picked up when running the test-extensions-unit.js script because the script was setting the env vars directly. Changing it to use all existing env vars and then modifying the values it needs for the tests.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2418205338

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 41.72%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 2 38.21%
Totals Coverage Status
Change from base Build 2418114042: -0.005%
Covered Lines: 27742
Relevant Lines: 62043

💛 - Coveralls

@Charles-Gagnon Charles-Gagnon merged commit bba66e4 into main Jun 1, 2022
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/fixEnvVars branch June 1, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants