[SQL-bindings] remove watcher for files #20250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasuBhog
requested review from
Charles-Gagnon,
lucyzhang929,
chlafreniere and
MaddyDev
as code owners
Pull Request Test Coverage Report for Build 2806275142
💛 - Coveralls |
lucyzhang929
approved these changes
Aug 5, 2022
| exitReason = ExitReason.error; | ||
| void vscode.window.showErrorMessage(constants.errorNewAzureFunction(error)); | ||
| } | ||
| // else an error would occur during the createFunction |
There was a problem hiding this comment.
// an error occurred during createFunction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need to watch for the completion of the createFunction file due to upgrades (here) with vscode-azurefunctions as well as past changes.
The main thing I will work on is that we get proper error handling from vscode-azurefunctions createFunction API call when a user cancels out of the quickpick options.