Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fse with AzExtFsUtils where possible #3268

Merged
merged 13 commits into from Aug 1, 2022
Merged

Replace fse with AzExtFsUtils where possible #3268

merged 13 commits into from Aug 1, 2022

Conversation

nturinski
Copy link
Member

@nturinski nturinski commented Jul 29, 2022

I couldn't get rid of fse entirely unfortunately...

  • There's a createWriteStream command in requestUtils that there's no equivalent in workspace.fs
  • The gulpfile doesn't actually have access to the utils package because the gulpfile doesn't run with the extension as far as I know. Whenever one is resolved, we should be able to move fse-extra to a devDependency or replace with fs calls
  • A couple of calls to copy had to have the "overwrite" property added to them. It was causing issues in the tests when the backup templates were being updated.

@nturinski nturinski requested a review from a team as a code owner July 29, 2022 23:11
@bwateratmsft
Copy link
Contributor

I couldn't get rid of fse entirely unfortunately...

  • There's a createWriteStream command in requestUtils that there's no equivalent in workspace.fs

Can't we make our own leveraging fs.writeFile along with an in-memory stream buffer?

@nturinski
Copy link
Member Author

I couldn't get rid of fse entirely unfortunately...

  • There's a createWriteStream command in requestUtils that there's no equivalent in workspace.fs

Can't we make our own leveraging fs.writeFile along with an in-memory stream buffer?

Yeah, I think we can but I wanted to do that separately just since it's a bit more of a complex change than just changing out some fs calls with VS Code's implementationm

@nturinski nturinski merged commit c27703a into main Aug 1, 2022
@nturinski nturinski deleted the nat/useFsUtils branch August 1, 2022 18:51
@microsoft microsoft locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants