Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Migration] Bug fixes & Validations. #25008

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

stuti149
Copy link
Contributor

1.The targetSelectionPage currently has a IaaS extension mode check for SQL VM targets. This check is no longer needed and is removed.
The SQLVM team has asked that this validation check be removed as it no longer applies. The behavior was observed during a customer call for the following incident:
https://portal.microsofticm.com/imp/v3/incidents/details/429943675/home

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6939321071

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.568%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 46.46%
Totals Coverage Status
Change from base Build 6937690638: -0.001%
Covered Lines: 30790
Relevant Lines: 69372

💛 - Coveralls

@stuti149 stuti149 merged commit 34f099d into main Nov 27, 2023
13 checks passed
@stuti149 stuti149 deleted the stutijain/add-validations branch November 27, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants