Updating signing tasks to use .NET 6 #25021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjin
requested review from
kisantia,
Charles-Gagnon,
alanrenmsft,
chlafreniere,
SakshiS-harma and
cheenamalhotra
Pull Request Test Coverage Report for Build 6961800062Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
build/azure-pipelines/darwin/sql-product-build-darwin-signing.yml
Outdated
Show resolved
Hide resolved
kisantia
approved these changes
Nov 22, 2023
|
Should the STS pipeline also be updated to use this updated signing task? Doesn't look like the STS pipelines are failing yet, but might be good to update those to use the new task too |
Yup, can do. |
Charles-Gagnon
approved these changes
Nov 22, 2023
cheenamalhotra
approved these changes
Nov 22, 2023
|
I'll proceed to merge, since Product builds have been failing.. |
cheenamalhotra
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Updating signing tasks to EsrpCodeSigning@3 * Updating .NET versions * removing UseDotNet steps * Restoring UseDotNet for linux builds
kisantia
pushed a commit
that referenced
this pull request
Jan 3, 2024
kisantia
pushed a commit
that referenced
this pull request
Jan 4, 2024
kisantia
pushed a commit
that referenced
this pull request
Jan 8, 2024
kisantia
added a commit
that referenced
this pull request
Jan 8, 2024
* Codesign unis000.exe with ESRP client (#25089) * update version to 1.41.3 * Use python 3.11.x in GitHub workflows (#25019) (#25113) * Use python v3.11 for Darwin (#24976) (#25115) Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com> * Updating signing tasks to use .NET 6 (#25021) (#25160) * Updating signing tasks to EsrpCodeSigning@3 * Updating .NET versions * removing UseDotNet steps * Restoring UseDotNet for linux builds Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com> * Use python 3.11 (#24646) * Fix duplicate setup-python in windows ci * change node version back to 16 for github workflows --------- Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com> Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com> Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful run (minus release)