Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msft-golang: drop explicit VERSION in build #3833

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Sep 24, 2022

Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Drop the explicit VERSION info while build. msft-golang now ships with this file pre-populated

Change Log
  • Drop the explicit VERSION for build.
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
  • NA
Test Methodology
  • Local Build with RUN_CHECK=y

Buddy Build:

Reference: microsoft/go#262
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@ghost ghost added Packaging main PR Destined for main labels Sep 24, 2022
@mfrw mfrw marked this pull request as ready for review September 24, 2022 06:56
@mfrw mfrw requested a review from a team as a code owner September 24, 2022 06:56
@mfrw mfrw merged commit 37d643c into main Sep 27, 2022
@mfrw mfrw deleted the mfrw/fix-msft-golang-fips branch September 27, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants