Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tobiasb/CVE 2023 28155 reaper #5560

Closed

Conversation

tobiasb-ms
Copy link
Contributor

@tobiasb-ms tobiasb-ms commented May 23, 2023

DRAFT--IGNORE

Merge Checklist
  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch reaper to fix CVE-2023-28155, which is a vulnerability in the request npm module, upon which reaper depends. This is somewhat complicated by the fact that request has been deprecated and is no longer taking updates. The patch is actually adapted from a pull request that was never and will never be merged.

Change Log

Patch CVE-2023-28155

Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

trungams and others added 25 commits May 18, 2023 15:30
microsoft#5529)

* Upgrade cloud-hypervisor to 31.1, kernel-mshv to 5-15-110, and kernel-uvm to 5-15-110 as part of LSG release v2305.11.1

* update manifest

* install bzImage
Add rootfs partition name in gen2 market place image
* Update moby-containerd-cc to 1.7.1 to fix unit test TestSnapshotterFromPodSandboxConfig
* Add ldap support to sudo

ALlow ldap to be used to configure sudo

* Updated 1.8.15-4 of commit in change log

rpmlint was failing as date and day did not match up, correcting
day to pass rpmlint

* Address PR commnts

- Removing ldap path and defauting to default config path
- Changing openldap to openldap-devel
* updating to v1.11.2

* Fixing bogus date warning

* Removing patch for CVE-2023-25165 as it is patched in the upgrade

* Removing patch for CVE-2023-25165 as it is patched in the upgrade

* Updating prep section to work withouth patch

* Fixing linting error
* Upgrade lua to 5.4.4 to fix CVE-2021-44964

* Update signature file manually

* Update toolchain build scripts for lua

* Remove patches that were already merged to lua-5.4.4

* Fix typo in changelog
Provide k8s-cni in cni-plugins

---------

Co-authored-by: Betty Lakes <bettylakes@microsoft.com>
* Fix CVE-2023-29194 by upgrading vitess to version 16.0.2

* Updage cgmanifest.json with correct version
* Update CVE-2022-37601.patch to fix multiple occurances

loader-utils module is used by multiple other modules which reaper is
depending upon. Instead of reusing already downloaded code, npm
redownloades the same module at different subtree level of node_modules.
So the same CVE has to be fixed in other two places as well.

* Addressed review comments
@tobiasb-ms tobiasb-ms force-pushed the tobiasb/CVE-2023-28155-reaper branch from c28f407 to 35d2f6a Compare May 24, 2023 20:17
@tobiasb-ms tobiasb-ms closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet