Beta 3 (#234)

* Drop spectre failure level to warning. * Update test * Update tests.
microsoft · Mar 21, 2019 · f9bad0c · f9bad0c
1 parent 6fa4680
commit f9bad0c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/SetCurrentVersion.cmd b/SetCurrentVersion.cmd
@@ -1,7 +1,7 @@
 set MAJOR_PREVIOUS=1
 set MINOR_PREVIOUS=6
 set PATCH_PREVIOUS=0
-set PRERELEASE_PREVIOUS=-beta.2
+set PRERELEASE_PREVIOUS=-beta.3
 
 set MAJOR=1
 set MINOR=6

diff --git a/src/BinSkim.Rules/PERules/BA2024.EnableSpectreMitigations.cs b/src/BinSkim.Rules/PERules/BA2024.EnableSpectreMitigations.cs
@@ -356,7 +356,7 @@ public override void AnalyzePortableExecutableAndPdb(BinaryAnalyzerContext conte
                 // switch and it is not possible to update to a toolset that supports /Qspectre).
                 // The following modules are out of policy: {1}
                 context.Logger.Log(this,
-                    RuleUtilities.BuildResult(FailureLevel.Error, context, null,
+                    RuleUtilities.BuildResult(FailureLevel.Warning, context, null,
                     nameof(RuleResources.BA2024_Warning),
                         context.TargetUri.GetFileName(),
                         sb.ToString()));

diff --git a/src/ReleaseHistory.md b/src/ReleaseHistory.md
@@ -75,3 +75,6 @@
 * Fix Linux NuGet packaging to include BinSkim executable missing in 1.6.0-beta.1
 * Update to pre-release SARIF v2 output format (sarif-2.0.0-csd.2.beta.2019-01-24)
 * Provide for SARIF v1 or v2 file format export. Default is v1 until SARIF v2 is final.
+
+## **v1.6.0-beta.3** [NuGet Package](https://www.nuget.org/packages/Microsoft.CodeAnalysis.BinSkim/1.6.0-beta.3)
+* Drop Spectre analysis to warning
diff --git a/src/Test.FunctionalTests.BinSkim.Rules/TestMessageLogger.cs b/src/Test.FunctionalTests.BinSkim.Rules/TestMessageLogger.cs
@@ -84,6 +84,12 @@ public void NoteTestResult(FailureLevel messageKind, string targetPath)
                     break;
                 }
 
+                case FailureLevel.Warning:
+                {
+                    FailTargets.Add(targetPath);
+                    break;
+                }
+
                 case FailureLevel.Note:
                 {
                     throw new NotImplementedException();