Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress NU1701 for the Azure Project #1334

Merged
merged 1 commit into from Jan 29, 2019
Merged

Supress NU1701 for the Azure Project #1334

merged 1 commit into from Jan 29, 2019

Conversation

cleemullins
Copy link
Contributor

The KeyVault.Core package ( GitHub Repo here ), picked up as a transitive dependency of the Azure Storage libraries doesn't yet support NetStandard20. I confirmed with the Azure Storage team that this warning is fine, and can be supressed.

[12:20 PM] Keith Farmer
So, our only dependency on that is the definitions of two interfaces, which are stable. Not the implementation. The warning should be ignorable in that case.

It does appear the Azure SDK team is "in-process" of supporting NetStandard20 as seen in this Commit.

We cannot apply the no-warn suppression directly to the package links below as they're not picked up across transitive dependencies. See this GitHub Issue for details.

Copy link
Contributor

@drub0y drub0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good from a build perspective.

I do wonder if this warning in particular is worth silencing or just letting it keep making noise so we remember to keep checking if there's a newer package we can update to. I don't think there's a right answer, so totally your call.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 47947

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.97%

Totals Coverage Status
Change from base Build 47941: 0.0%
Covered Lines: 3408
Relevant Lines: 5014

💛 - Coveralls

@cleemullins cleemullins merged commit 3840010 into master Jan 29, 2019
@cleemullins cleemullins deleted the CLM/NU1701 branch January 29, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants