Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supress NU1701 for the Azure Project #1334

Merged
merged 1 commit into from Jan 29, 2019
Merged

Supress NU1701 for the Azure Project #1334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions libraries/Microsoft.Bot.Builder.Azure/Microsoft.Bot.Builder.Azure.csproj
View file
Open in desktop
Expand Up @@ -22,6 +22,21 @@
<PropertyGroup>
<CodeAnalysisRuleSet>Microsoft.Bot.Builder.Azure.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>

<PropertyGroup>
<!-- The KeyVault package, picked up as a transitive dependency of the Azure Storage libraries
doesn't yet support NetStandard20. I confirmed with the Azure Storage team that this warning
is fine, and can be supressed.

It does appear the Azure SDK team is "in-process" of supporting NetStandard20 as seen in this
Commit: https://github.com/Azure/azure-sdk-for-net/commit/b0d42d14bfe92a24996826b2487ba592e644f581

We cannot apply the no-warn supression directly to the package links below as
they're not picked up across transitive dependencies. See this GitHub Issue for details:
https://github.com/NuGet/Home/issues/5740
-->
<NoWarn>NU1701</NoWarn>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="AsyncUsageAnalyzers" Version="1.0.0-alpha003" PrivateAssets="all" />
Expand Down