[StyleCop] Fix stylecop warnings on Bot.Builder.TestBot.WebApi #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasper-az
changed the title
Pull Request Test Coverage Report for Build 53587
💛 - Coveralls |
|
cleemullins
approved these changes
Apr 9, 2019
johnataylor
reviewed
Apr 9, 2019
| protected readonly Dialog _dialog; | ||
| protected readonly BotState _conversationState; | ||
| protected readonly BotState _userState; | ||
| protected readonly ILogger _logger; | ||
| #pragma warning restore SA1401 // Fields should be private |
There was a problem hiding this comment.
This code is an exact drop of the core bot sample (in this case the webapi sample)
It would be great if we can maintain the consistency, that makes updates much easier. So can we exclude this warning outside of the code in an external rules file. That is possible with stylecop isn't it?
| { | ||
| DestinationStepAsync, | ||
| OriginStepAsync, | ||
| TravelDateStepAsync, | ||
| ConfirmStepAsync, | ||
| FinalStepAsync, | ||
| })); | ||
| }; | ||
| AddDialog(new WaterfallDialog(nameof(WaterfallDialog), steps)); |
There was a problem hiding this comment.
Why?
Can we just keep this consistent with the original sample?
Specifically, sure if you want to make this change for some reason can you also make it in the sample.
| { | ||
| InitialStepAsync, | ||
| FinalStepAsync, | ||
| })); |
|
|
||
| // The initial child Dialog to run. | ||
| InitialDialogId = nameof(WaterfallDialog); | ||
| } | ||
|
|
||
| private static Task<bool> DateTimePromptValidator(PromptValidatorContext<IList<DateTimeResolution>> promptContext, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Why move this?
The original order was intentional. we can move it if you like but exactly why would we do that?
(and again consistency with the original sample)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve stylecop issues on Bot.Builder.TestBot.WebApi
Changes made: