Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Xml doc generation from debug target. #2085

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Removed Xml doc generation from debug target. #2085

merged 1 commit into from
Jun 18, 2019

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Jun 17, 2019

No description provided.

@gabog gabog requested a review from cleemullins June 17, 2019 23:32
@gabog gabog mentioned this pull request Jun 17, 2019
Merged
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 65468

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.687%
Totals Coverage Status
Change from base Build 65465: 0.0%
Covered Lines: 4512
Relevant Lines: 6294
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

tomlm
tomlm approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit 7f37fbd into master Jun 18, 2019
@tomlm tomlm deleted the gabog/RemoveXmlDocumentationFromDebug branch June 18, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

@cleemullins cleemullins Awaiting requested review from cleemullins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gabog @coveralls @fuselabs @tomlm