Initialize security context for Skill ContinueConversationAsync calls #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosscastro
approved these changes
Jan 14, 2020
…t is only done when the request has been handled by the skill infrastructure.
gabog
changed the title
gabog
added a commit
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3245
Adds code to initialize _appCredentialMap and _connectorClients cache with default instances during ContinueConversationAsync calls.
This PR also adds the serviceUrl of the reference activity to the AppCredentials.TrustServiceUrl list.
This is needed because these in memory objects are not initialized unless the channel invokes the bot first. In some proactive scenarios and skills, the server may not have been initialized and this cases a 401 when the bot tries to respond to the channel.