[Skills] TrustServiceUrl from original conversationReference in SkillHandler #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabog
approved these changes
Jan 16, 2020
carlosscastro
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1580 in
4.7Description
Add
AppCredentials.trustServiceUrl()call in SkillHandler to trust serviceUrl that was received in message from channel.This allows for all instances of the parent bot to fetch a token when it attempts to forward the activity from the Skill to the User (via the use of the SkillHandler class).
Additional Context (C#)
Testing
Manually tested by having one parent bot use the endpoint of the second parent bot as the serviceUrl for activities sent to the skill.
Added specific unit test for verifying the serviceUrl is trusted after SkillHandler.processActivity() is run.