Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO Protocol Support #3360

Merged
merged 31 commits into from
Feb 24, 2020
Merged

SSO Protocol Support #3360

merged 31 commits into from
Feb 24, 2020

Conversation

Jeffders
Copy link
Member

@Jeffders Jeffders commented Feb 8, 2020

fixes #3356
Added schema updates, token service API calls, and OAuthPrompt updates to support SSO (single sign on) protocol operations for user login flows.

@ted and @gabog , can you make sure your skill OAuth calls are still right?

Eric Dahlvang and others added 23 commits December 10, 2019 16:37
…#3244)

* Added code to initialize security context during ContinueConversationAsync.

* Addressed comments from carlos.

* More comments.

* Wrapped the code to add trustServiceUrl in a skills check to ensure it is only done when the request has been handled by the skill infrastructure.
…to prevent the ASP.Net runtime from registering it as a controller.
…ollerAbstract

Made ChannelServiceController abstract
…3294)

* Enabled Deserialization for OAuthPrompt Dialog With TypeHandling.None

* Return default(T) incase of null object

* Account for obj type equal to JArray
@coveralls
Copy link
Collaborator

coveralls commented Feb 11, 2020

bothosting.runtime@bf.ai added 2 commits February 14, 2020 14:22
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

}
else
{
throw new InvalidOperationException($"ExchangeAsyncAsync returned improper result: {result.GetType()}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: ExchangeAsync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO protocol implementation
9 participants