Fix errors when From is null in telemetry #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
changed the title
This was referenced Feb 26, 2020
Closed
ShYuPe
pushed a commit
to ShYuPe/botbuilder-dotnet
that referenced
this pull request
Aug 25, 2020
* Fix errors when From is null in telemetry microsoft#3436 * black Co-authored-by: Eric Dahlvang <v-eridah@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3395
If
TelemetryLoggerMiddlewareis used and thenCreateConversationAsync()is called, there are cases whereActivity.Fromwill be null, which causes things like this to throw:Changes:
Adds a few null-conditional operators, where appropriate.
Testing:
Added one test which calls
CreateConversationAsync()while ensuring theActivity.Fromis null.