Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional null check in Telemetry #3452

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Add additional null check in Telemetry #3452

merged 1 commit into from
Feb 28, 2020

Conversation

mdrichardson
Copy link
Contributor

Fixes: #3442

Similar to this PR, but adds a null check I missed (plus an additional test).

From

if (items.ContainsKey(TelemetryBotIdInitializer.BotActivityKey))

To

if (items != null && items.ContainsKey(TelemetryBotIdInitializer.BotActivityKey))

tomlm
tomlm approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit e7686cb into master Feb 28, 2020
@tomlm tomlm deleted the AnotherNullTelemFix branch February 28, 2020 01:29
This was referenced Feb 28, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft Teams: Bot Framework + Application Insights proactive messages cause null exception
2 participants
@mdrichardson @tomlm