Streaming: Add TimeOut centralized methods that are also debugger friendly #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosscastro
added a commit
that referenced
this pull request
Oct 29, 2021
* E2E test infra with basic sample test. * Activity tests with suggested actions and attachments. * Chunk streams if > 3KB. * Perf optimization when chunking of stream not needed. * Crash/Disconnect/Cancellation tests. * Refactor to enable concurrency testing. * Concurrency test. * Fix build break. * Fix build break. * Fix test failure. * Pass CancellationToken in server and client. * CancellationToken in BotFrameworkHttpAdapter. * Fix test issue. * Fix test. * Optimize chunking for non-memory streams. * Chunk optimization for MemoryStream * Streaming: Add TimeOut centralized methods that are also debugger friendly (#5938) * Streaming: add default timeout extension method that is debugger friendly * Streaming session: clean up usings * Streaming client: fix credentials * Remove streaming library dependency on ASP.NET core Http. (#5937) * Remove streaming library dependency on ASP.NET core Http. * Remove Microsoft.AspNetCore.Connections.Abstractions dependency. * Dispose socket. * Dispose socket in StreamingConnection. Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>
msomanathan
added a commit
that referenced
this pull request
Oct 29, 2021
* E2E test infra with basic sample test. * Activity tests with suggested actions and attachments. * Chunk streams if > 3KB. * Perf optimization when chunking of stream not needed. * Crash/Disconnect/Cancellation tests. * Refactor to enable concurrency testing. * Concurrency test. * Fix build break. * Fix build break. * Fix test failure. * Pass CancellationToken in server and client. * CancellationToken in BotFrameworkHttpAdapter. * Fix test issue. * Fix test. * Optimize chunking for non-memory streams. * Chunk optimization for MemoryStream * Streaming: Add TimeOut centralized methods that are also debugger friendly (#5938) * Streaming: add default timeout extension method that is debugger friendly * Streaming session: clean up usings * Streaming client: fix credentials * Remove streaming library dependency on ASP.NET core Http. (#5937) * Remove streaming library dependency on ASP.NET core Http. * Remove Microsoft.AspNetCore.Connections.Abstractions dependency. * Dispose socket. * Dispose socket in StreamingConnection. Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>
msomanathan
added a commit
that referenced
this pull request
Oct 29, 2021
* E2E test infra with basic sample test. * Activity tests with suggested actions and attachments. * Chunk streams if > 3KB. * Perf optimization when chunking of stream not needed. * Crash/Disconnect/Cancellation tests. * Refactor to enable concurrency testing. * Concurrency test. * Fix build break. * Fix build break. * Fix test failure. * Pass CancellationToken in server and client. * CancellationToken in BotFrameworkHttpAdapter. * Fix test issue. * Fix test. * Optimize chunking for non-memory streams. * Chunk optimization for MemoryStream * Streaming: Add TimeOut centralized methods that are also debugger friendly (#5938) * Streaming: add default timeout extension method that is debugger friendly * Streaming session: clean up usings * Streaming client: fix credentials * Remove streaming library dependency on ASP.NET core Http. (#5937) * Remove streaming library dependency on ASP.NET core Http. * Remove Microsoft.AspNetCore.Connections.Abstractions dependency. * Dispose socket. * Dispose socket in StreamingConnection. Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com> Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor