Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor TestMultiLangImport tests #2128

Merged
merged 1 commit into from
Apr 29, 2020
Merged

refactor TestMultiLangImport tests #2128

merged 1 commit into from
Apr 29, 2020

Conversation

stevengum
Copy link
Member

Fixes test timeout that caused Build 1255615's failure for commit 18cb982

Same refactoring as #2076

@coveralls
Copy link

coveralls commented Apr 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 126149

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 79.794%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 125619: -0.08%
Covered Lines: 12348
Relevant Lines: 14762
💛 - Coveralls

@stevengum stevengum merged commit cd91bb0 into master Apr 29, 2020
@stevengum stevengum deleted the stgum/lg branch April 29, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munozemilio munozemilio munozemilio approved these changes

@chon219 chon219 Awaiting requested review from chon219

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@Danieladu Danieladu Awaiting requested review from Danieladu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevengum @coveralls @munozemilio